This is an archive of the discontinued LLVM Phabricator instance.

Differential D86663

[test][Inliner] Make always-inline.ll work with NPM
ClosedPublic

Authored by aeubanks on Aug 26 2020, 4:58 PM.

Details

Reviewers
ychen
asbirlea
Commits
rG8bdb98c78121: [test][Inliner] Make always-inline.ll work with NPM
Summary

The NPM doesn't support call-site alwaysinline as described in the comments.

Also make NPM runs more similar to legacy PM runs.

Diff Detail

Event Timeline

aeubanks created this revision.Aug 26 2020, 4:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 26 2020, 4:58 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
aeubanks requested review of this revision.Aug 26 2020, 4:58 PM
asbirlea accepted this revision.Aug 26 2020, 5:04 PM
This revision is now accepted and ready to land.Aug 26 2020, 5:04 PM
Harbormaster completed remote builds in B69694: Diff 288140.Aug 26 2020, 5:29 PM
ychen accepted this revision.Aug 27 2020, 9:55 AM
Closed by commit rG8bdb98c78121: [test][Inliner] Make always-inline.ll work with NPM (authored by aeubanks). · Explain WhyAug 27 2020, 10:01 AM
This revision was automatically updated to reflect the committed changes.
aeubanks added a commit: rG8bdb98c78121: [test][Inliner] Make always-inline.ll work with NPM.

Revision Contents

PathSize
llvm/
test/
Transforms/
Inline/
10 lines

Diff 288379

llvm/test/Transforms/Inline/always-inline.ll

; RUN: opt < %s -inline-threshold=0 -always-inline -S | FileCheck %s --check-prefix=CHECK --check-prefix=CHECK-CALL ; RUN: opt < %s -inline-threshold=0 -always-inline -enable-new-pm=0 -S | FileCheck %s --check-prefix=CHECK --check-prefix=CHECK-CALL
; ;
; Ensure the threshold has no impact on these decisions. ; Ensure the threshold has no impact on these decisions.
; RUN: opt < %s -inline-threshold=20000000 -always-inline -S | FileCheck %s --check-prefix=CHECK --check-prefix=CHECK-CALL ; RUN: opt < %s -inline-threshold=20000000 -always-inline -enable-new-pm=0 -S | FileCheck %s --check-prefix=CHECK --check-prefix=CHECK-CALL
; RUN: opt < %s -inline-threshold=-20000000 -always-inline -S | FileCheck %s --check-prefix=CHECK --check-prefix=CHECK-CALL ; RUN: opt < %s -inline-threshold=-20000000 -always-inline -enable-new-pm=0 -S | FileCheck %s --check-prefix=CHECK --check-prefix=CHECK-CALL
; ;
; The new pass manager doesn't re-use any threshold based infrastructure for ; The new pass manager doesn't re-use any threshold based infrastructure for
; the always inliner, but test that we get the correct result. The new PM ; the always inliner, but test that we get the correct result. The new PM
; always inliner also doesn't support inlining call-site alwaysinline ; always inliner also doesn't support inlining call-site alwaysinline
; annotations. It isn't clear that this is a reasonable use case for ; annotations. It isn't clear that this is a reasonable use case for
; 'alwaysinline'. ; 'alwaysinline'.
; RUN: opt < %s -passes=always-inline -S | FileCheck %s --check-prefix=CHECK ; RUN: opt < %s -inline-threshold=0 -passes=always-inline -S | FileCheck %s --check-prefix=CHECK
; RUN: opt < %s -inline-threshold=20000000 -passes=always-inline -S | FileCheck %s --check-prefix=CHECK
; RUN: opt < %s -inline-threshold=-20000000 -passes=always-inline -S | FileCheck %s --check-prefix=CHECK
define internal i32 @inner1() alwaysinline { define internal i32 @inner1() alwaysinline {
; CHECK-NOT: @inner1( ; CHECK-NOT: @inner1(
ret i32 1 ret i32 1
} }
define i32 @outer1() { define i32 @outer1() {
; CHECK-LABEL: @outer1( ; CHECK-LABEL: @outer1(
; CHECK-NOT: call ; CHECK-NOT: call
▲ Show 20 Lines • Show All 298 Lines • Show Last 20 Lines