This is an archive of the discontinued LLVM Phabricator instance.

Use properlyDominates in RDFLiveness when sorting on dominance.
ClosedPublic

Authored by pranavb on Aug 26 2020, 1:55 PM.

Details

Summary

When looking for all reaching definitions, we sort basic blocks on dominance. When sorting looking for properlyDominates() handles the case A == B.

Diff Detail

Event Timeline

pranavb created this revision.Aug 26 2020, 1:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 26 2020, 1:55 PM
pranavb requested review of this revision.Aug 26 2020, 1:55 PM
asbirlea accepted this revision.Aug 26 2020, 2:16 PM
This revision is now accepted and ready to land.Aug 26 2020, 2:16 PM
kparzysz accepted this revision.Aug 26 2020, 2:18 PM
xbolva00 added inline comments.
llvm/lib/CodeGen/RDFLiveness.cpp
236–237

llvm::sort