This is an archive of the discontinued LLVM Phabricator instance.

[SyntaxTree] Refactor `NodeRole`s
ClosedPublic

Authored by eduucaldas on Aug 26 2020, 9:22 AM.

Details

Summary

Previously a NodeRole would generally be prefixed with the NodeKind,
we remove this prefix, as it we redundant and made tests more noisy.

Diff Detail

Event Timeline

eduucaldas created this revision.Aug 26 2020, 9:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 26 2020, 9:22 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
eduucaldas requested review of this revision.Aug 26 2020, 9:22 AM
gribozavr2 accepted this revision.Aug 26 2020, 10:04 AM
gribozavr2 added inline comments.
clang/include/clang/Tooling/Syntax/Nodes.h
156–181

I'd suggest to remove the cross-references in the comments. In my experience, one is much better off using "find references" in the IDE. The comments can (and do) rapidly become stale.

This revision is now accepted and ready to land.Aug 26 2020, 10:04 AM

answer comment.

eduucaldas marked an inline comment as done.Aug 26 2020, 10:06 PM
This revision was landed with ongoing or failed builds.Aug 26 2020, 10:16 PM
This revision was automatically updated to reflect the committed changes.