Previously a NodeRole would generally be prefixed with the NodeKind,
we remove this prefix, as it we redundant and made tests more noisy.
Details
Details
- Reviewers
gribozavr2 - Commits
- rG718e550cd036: [SyntaxTree] Refactor `NodeRole`s
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Unit Tests
Time | Test | |
---|---|---|
410 ms | linux > lld.MachO::objc.s | |
380 ms | windows > lld.MachO::objc.s |
Event Timeline
clang/include/clang/Tooling/Syntax/Nodes.h | ||
---|---|---|
156–181 | I'd suggest to remove the cross-references in the comments. In my experience, one is much better off using "find references" in the IDE. The comments can (and do) rapidly become stale. |
I'd suggest to remove the cross-references in the comments. In my experience, one is much better off using "find references" in the IDE. The comments can (and do) rapidly become stale.