This is an archive of the discontinued LLVM Phabricator instance.

[2/5] [MC] [Win64EH] Update the AArch64/seh.s test slightly. NFC.
ClosedPublic

Authored by mstorsjo on Aug 25 2020, 4:30 AM.

Details

Summary

Update the comment stating the aim of the test - this is currently only checking that these assembler directives doesn't cause the assembler to fail, but the results of the testcase aren't particularly correct yet.

Remove bits of the testcase that are even less likely to be found in the wild (the .seh_startchained/.seh_endchained block), where the testcase currently doesn't really generate anything interesting anyway.

Diff Detail

Event Timeline

mstorsjo created this revision.Aug 25 2020, 4:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 25 2020, 4:30 AM
mstorsjo retitled this revision from [MC] [Win64EH] Update the AArch64/seh.s test slightly. NFC. to [2/5] [MC] [Win64EH] Update the AArch64/seh.s test slightly. NFC..
efriedma accepted this revision.Aug 25 2020, 1:30 PM

LGTM. (I'm not completely sure where you're going with this, but I'll trust you have an appropriate plan.)

This revision is now accepted and ready to land.Aug 25 2020, 1:30 PM