[compiler-rt][asan][test] Set LD_LIBRARY_PATH_{32,64} on Solaris

[ro]

Summary

The dynamically linked ASan tests rely on LD_LIBRARY_PATH to find libclang_rt.asan-*.so at runtime.

However, the Solaris runtime linker ld.so.1 also supports more specific variables: LD_LIBRARY_PATH_32 and LD_LIBRARY_PATH_64 respectively. If those happen to be set, LD_LIBRARY_PATH is ignored. In such a case, all dynamically linked ASan tests FAIL. For i386 alone, this affects about 200 tests.

The following patch fixes that by also setting LD_LIBRARY_PATH_{32,64} on Solaris.

Tested on amd64-pc-solaris2.11 both with only LD_LIBRARY_PATH set and with LD_LIBRARY_PATH_{32,64} set too.

[vitalybuka]

LGTM if it works. I don't have SunOS to test.

[ro]

In D86333#2235129, @vitalybuka wrote:

LGTM if it works. I don't have SunOS to test.

Thanks. I meant to provide Solaris 11.4/sparcv9 and amd64 systems for the GCC compile farm, but that proved difficult for legal reasons. There is a Solaris 11.3/sparcv9 system there (gcc211), but llvm master doesn't currently even build on 11.3 due to a couple of issues (libc, ld.so.1, ld) and it's uncertain if it can be beaten into shape to be somewhat useful.

compiler-rt/test/asan/Unit/lit.site.cfg.py.in

new_ld_library_path = os.path.pathsep.join(
     (new_path, config.environment.get('LD_LIBRARY_PATH', '')))
   config.environment['LD_LIBRARY_PATH'] = new_ld_library_path
 
   if platform.system() == 'FreeBSD':
     new_ld_32_library_path = os.path.pathsep.join(
       (new_path, config.environment.get('LD_32_LIBRARY_PATH', '')))
     config.environment['LD_32_LIBRARY_PATH'] = new_ld_32_library_path
 
+  if platform.system() == 'SunOS':
+    new_ld_library_path_32 = os.path.pathsep.join(
+      (new_path, config.environment.get('LD_LIBRARY_PATH_32', '')))
+    config.environment['LD_32_LIBRARY_PATH'] = new_ld_library_path_32
+
+    new_ld_library_path_64 = os.path.pathsep.join(
+      (new_path, config.environment.get('LD_LIBRARY_PATH_64', '')))
+    config.environment['LD_64_LIBRARY_PATH'] = new_ld_library_path_64
+
 # Setup config name.
 config.name = 'AddressSanitizer-Unit'
 
 # Setup test source and exec root. For unit tests, we define
 # it as build directory with ASan unit tests.
 # FIXME: De-hardcode this path.
 if @ASAN_TEST_DYNAMIC@:
   test_dir = "dynamic"

compiler-rt/test/asan/lit.cfg.py

def push_dynamic_library_lookup_path(config, new_path):
   config.environment[dynamic_library_lookup_var] = new_ld_library_path
 
   if platform.system() == 'FreeBSD':
     dynamic_library_lookup_var = 'LD_32_LIBRARY_PATH'
     new_ld_32_library_path = os.path.pathsep.join(
       (new_path, config.environment.get(dynamic_library_lookup_var, '')))
     config.environment[dynamic_library_lookup_var] = new_ld_32_library_path
 
+  if platform.system() == 'SunOS':
+    dynamic_library_lookup_var = 'LD_LIBRARY_PATH_32'
+    new_ld_library_path_32 = os.path.pathsep.join(
+      (new_path, config.environment.get(dynamic_library_lookup_var, '')))
+    config.environment[dynamic_library_lookup_var] = new_ld_library_path_32
+
+    dynamic_library_lookup_var = 'LD_LIBRARY_PATH_64'
+    new_ld_library_path_64 = os.path.pathsep.join(
+      (new_path, config.environment.get(dynamic_library_lookup_var, '')))
+    config.environment[dynamic_library_lookup_var] = new_ld_library_path_64
+
 # Setup config name.
 config.name = 'AddressSanitizer' + config.name_suffix
 
 # Platform-specific default ASAN_OPTIONS for lit tests.
 default_asan_opts = list(config.default_sanitizer_opts)
 
 # On Darwin, leak checking is not enabled by default. Enable for x86_64
 # tests to prevent regressions