Page MenuHomePhabricator

[libcxx/variant] Correctly propagate return type of the visitor.
ClosedPublic

Authored by mpark on Aug 14 2020, 4:52 PM.

Details

Summary

The tests for it were missing so I've added them.

Diff Detail

Event Timeline

mpark created this revision.Aug 14 2020, 4:52 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 14 2020, 4:52 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
mpark requested review of this revision.Aug 14 2020, 4:52 PM
EricWF accepted this revision.Aug 17 2020, 10:48 AM

LGTM, this fixes some build failures at Google.

Thanks for the fix!

This revision is now accepted and ready to land.Aug 17 2020, 10:48 AM
This revision was landed with ongoing or failed builds.Aug 17 2020, 10:55 AM
This revision was automatically updated to reflect the committed changes.