This is an archive of the discontinued LLVM Phabricator instance.

[SyntaxTree] Split `TreeTestBase` into header and source
ClosedPublic

Authored by eduucaldas on Aug 13 2020, 9:12 AM.

Diff Detail

Event Timeline

eduucaldas created this revision.Aug 13 2020, 9:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 13 2020, 9:12 AM
eduucaldas requested review of this revision.Aug 13 2020, 9:12 AM

Switch to using directive on source files

Fix the diff base

Remove unused SyntaxTreeTest::addFile

eduucaldas added inline comments.
clang/unittests/Tooling/Syntax/BuildTreeTest.cpp
16–17

Following the style-guide

clang/unittests/Tooling/Syntax/MutationsTest.cpp
15 ↗(On Diff #285421)

Moved from TreeTestBase as this include was only used by MutationsTest

clang/unittests/Tooling/Syntax/TreeTestBase.h
163–169

Removed because unused

gribozavr2 accepted this revision.Aug 13 2020, 10:38 AM
gribozavr2 added inline comments.
clang/unittests/Tooling/Syntax/TreeTestBase.cpp
39

No need to wrap static functions in unnamed namespaces.

This revision is now accepted and ready to land.Aug 13 2020, 10:38 AM

remove static inside anonymous namespace

eduucaldas marked an inline comment as done.Aug 14 2020, 12:28 AM
This revision was landed with ongoing or failed builds.Aug 14 2020, 12:42 AM
This revision was automatically updated to reflect the committed changes.