Page MenuHomePhabricator

[OpenMPOpt][SplitMemTransfer] Is it possible/worth it to split the runtime call?
AbandonedPublic

Authored by hamax97 on Aug 12 2020, 8:43 AM.

Details

Summary
  • Fix to function canBeMovedUpwards.
  • Declaration of function canBeMovedDownwards.

Diff Detail

Event Timeline

hamax97 created this revision.Aug 12 2020, 8:43 AM
hamax97 requested review of this revision.Aug 12 2020, 8:43 AM

Can you add parent revisions for this and maybe other related patches? It will be easier to know the order.

llvm/lib/Transforms/IPO/OpenMPOpt.cpp
1005–1006

If I'm not wrong canBeMovedDownwards() never returns nullptr?

1061

I'd put Instruction * here.
Also, Maybe put it in the while condition?

Can you add parent revisions for this and maybe other related patches? It will be easier to know the order.

Yes, I already did it. Sorry for not doing it before.

llvm/lib/Transforms/IPO/OpenMPOpt.cpp
1005–1006

Yes you're right. I'll it.

1061

Sure, I'll change it.

hamax97 updated this revision to Diff 285189.Aug 12 2020, 3:24 PM
  • Fix to canBeMovedDownwards.
hamax97 updated this revision to Diff 285193.Aug 12 2020, 3:32 PM
This comment was removed by hamax97.
hamax97 updated this revision to Diff 285195.Aug 12 2020, 3:34 PM

Sorry. Error updating last patch.

  • Fix to canBeMovedDownwards
hamax97 abandoned this revision.Aug 24 2020, 10:18 AM