This is an archive of the discontinued LLVM Phabricator instance.

[llvm-readobj/elf][test] - Refine --headers testing and the related code comment.
ClosedPublic

Authored by grimar on Aug 12 2020, 5:51 AM.

Details

Summary

Specifying --headers is equivalent to setting --file-headers,
--program-headers and --section-headers at the same time.

The existent test case uses a precompiled object and doesn't test the
output properly. This patch fixes it.

Diff Detail

Event Timeline

grimar created this revision.Aug 12 2020, 5:51 AM
Herald added a project: Restricted Project. · View Herald Transcript
grimar requested review of this revision.Aug 12 2020, 5:51 AM
jhenderson accepted this revision.Aug 13 2020, 1:19 AM

LGTM, thanks! Probably can have an NFC and/or test tag.

This revision is now accepted and ready to land.Aug 13 2020, 1:19 AM
grimar retitled this revision from [llvm-readobj/elf] - Refine --headers testing and the related code comment. to [llvm-readobj/elf][test] - Refine --headers testing and the related code comment..Aug 13 2020, 3:37 AM