[compiler-rt][asan][test] Skipt sanitizer_common tests on Sparc

[ro]

Summary

When building on sparc64-unknown-linux-gnu, I found that a large number of SanitizerCommon-asan-sparc*-Linux tests were FAILing, like

 SanitizerCommon-asan-sparc-Linux :: Linux/aligned_alloc-alignment.cpp
[...]
 SanitizerCommon-asan-sparcv9-Linux :: Linux/aligned_alloc-alignment.cpp
[...]

many of them due to

fatal error: error in backend: Function "_Z14User_OnSIGSEGViP9siginfo_tPv": over-aligned dynamic alloca not supported.

which breaks ASan on Sparc. Currently asan is only built for the benefit of gcc where it does work. However, when enabling the compilation in compiler-rt to make certain it continues to build, I missed compiler-rt/test/sanitizer_common when disabling ASan testing on Sparc (it's not yet enabled on Solaris).

This patch fixes the issue.

Tested on sparcv9-sun-solaris2.11 with the sanitizer_comon testsuite enabled.

[vitalybuka]

I would be nice to have some sparc build bot.

[ro]

In D85732#2214717, @vitalybuka wrote:

I would be nice to have some sparc build bot.

As it happens, we do. However, this doesn't help unfortunately since the sanitizer_common testsuite wasn't enable on Solaris.

compiler-rt (like the rest of LLVM` has the unfortunately habit of spreading testsuite configration over far too many places (cmake files, lit config both static and with substitutions), so it's easy to miss one.

When I landed the Solaris ports (both sparc and i386), I completely missed to enable testing sanitizer_common (and ubsan_minimal) on Solaris. The port had been developed in the gcc tree and I was barely familiar with cmake and lit at the time. Even now, it would be way better to have the testsuite enabled everywhere by default and only disable parts that need a particular feature based on that feature rather than static configuration.

compiler-rt/test/sanitizer_common/CMakeLists.txt

foreach(tool ${SUPPORTED_TOOLS})
   string(TOUPPER ${tool} tool_toupper)
   if(${tool_toupper}_SUPPORTED_ARCH AND NOT COMPILER_RT_STANDALONE_BUILD)
     list(APPEND SANITIZER_COMMON_TEST_DEPS ${tool})
   endif()
   set(TEST_ARCH ${${tool_toupper}_SUPPORTED_ARCH})
   if(APPLE)
     darwin_filter_host_archs(${tool_toupper}_SUPPORTED_ARCH TEST_ARCH)
   endif()
+  if(${tool} STREQUAL "asan")
+    list(REMOVE_ITEM TEST_ARCH sparc sparcv9)
+  endif()
 
   # TODO(dliew): We should iterate over the different
   # Apple platforms, not just macOS.
   foreach(arch ${TEST_ARCH})
     set(SANITIZER_COMMON_LIT_TEST_MODE ${tool})
     set(SANITIZER_COMMON_TEST_TARGET_ARCH ${arch})
     get_test_cc_for_arch(${arch} SANITIZER_COMMON_TEST_TARGET_CC SANITIZER_COMMON_TEST_TARGET_CFLAGS)
     set(CONFIG_NAME ${tool}-${arch}-${OS_NAME})