Page MenuHomePhabricator

[NFC][builtins] Make softfloat-related errors less noisy
Needs ReviewPublic

Authored by atrosinenko on Aug 11 2020, 7:07 AM.

Details

Summary

Choose SINGLE_PRECISION by default in fp_lib.h after manually #erroring when no precision is set. This eliminates cluttering log with lots of errors like "unknown type name 'fp_t'" after the descriptive error message was already generated manually. In this patch, I assume that #error cannot be silenced.

This makes clang-tidy output during differential review of patches more relevant for fp_*_impl.inc while checking macroses even stricter (checking that *exactly* one is defined instead of *at least* one is).

Example output of clang-tidy for fp_add_impl.inc:


Diff Detail

Event Timeline

atrosinenko created this revision.Aug 11 2020, 7:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 11 2020, 7:07 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
atrosinenko requested review of this revision.Aug 11 2020, 7:07 AM
atrosinenko edited the summary of this revision. (Show Details)Aug 11 2020, 7:12 AM
atrosinenko retitled this revision from [builtins] Make softfloat-related errors less noisy to [NFC][builtins] Make softfloat-related errors less noisy.Aug 14 2020, 3:41 AM
atrosinenko edited the summary of this revision. (Show Details)
atrosinenko added reviewers: efriedma, joerg.

Rebase the entire patch stack against the up-to-date master and re-upload.