[InstSimplify][test] Remove unused parameter in vscale.ll

[huihuiz]

why do we need this change?
insert element into undef is common to construct a vector, being fixed or scalable.

[aeubanks]

In D85688#2208127, @huihuiz wrote:

why do we need this change?
insert element into undef is common to construct a vector, being fixed or scalable.

I don't think that's the intention of this specific test given the name insert_extract_element_same_vec_idx_2. And also the unused parameter %a.
This is failing due after a local change to instsimplify and I think the test maybe isn't testing what it wants to test?

[huihuiz]

I don't think that's the intention of this specific test given the name insert_extract_element_same_vec_idx_2. And also the unused parameter %a.
This is failing due after a local change to instsimplify and I think the test maybe isn't testing what it wants to test?

The "same_vec_idx" refer to index "i64 4" , that's where the extractelement is extracting.
You can remove %a from function argument, that's added in error.

I think the undef should be kept.
Checking sequence insert+extract on a vector, being a existing vector, or under shouldn't matter.

[aeubanks]

instead, remove unused parameter

[aeubanks]

In D85688#2208136, @huihuiz wrote:

I don't think that's the intention of this specific test given the name insert_extract_element_same_vec_idx_2. And also the unused parameter %a.
This is failing due after a local change to instsimplify and I think the test maybe isn't testing what it wants to test?

The "same_vec_idx" refer to index "i64 4" , that's where the extractelement is extracting.
You can remove %a from function argument, that's added in error.

I think the undef should be kept.
Checking sequence insert+extract on a vector, being a existing vector, or under shouldn't matter.

That makes sense, thanks.

llvm/test/Transforms/InstSimplify/vscale.ll

 ; CHECK-LABEL: @extractelement_idx_large_bound(
 ; CHECK-NEXT:    [[R:%.*]] = extractelement <vscale x 4 x i32> [[A:%.*]], i64 12345
 ; CHECK-NEXT:    ret i32 [[R]]
 ;
   %r = extractelement <vscale x 4 x i32> %a, i64 12345
   ret i32 %r
 }
 
-define i32 @insert_extract_element_same_vec_idx_2(<vscale x 4 x i32> %a) {
+define i32 @insert_extract_element_same_vec_idx_2() {
 ; CHECK-LABEL: @insert_extract_element_same_vec_idx_2(
 ; CHECK-NEXT:    ret i32 1
 ;
   %v = insertelement <vscale x 4 x i32> undef, i32 1, i64 4
   %r = extractelement <vscale x 4 x i32> %v, i64 4
   ret i32 %r
 }