Page MenuHomePhabricator

[clang][Fuchsia] Add relative-vtables multilib
AcceptedPublic

Authored by leonardchan on Aug 7 2020, 5:34 PM.

Details

Reviewers
phosek
mcgrathr
Summary

This adds multilibs for Fuchsia that is built with the relative vtables ABI, one with and another without exceptions.

Diff Detail

Event Timeline

leonardchan created this revision.Aug 7 2020, 5:34 PM
leonardchan requested review of this revision.Aug 7 2020, 5:34 PM
leonardchan edited the summary of this revision. (Show Details)
leonardchan edited the summary of this revision. (Show Details)
leonardchan edited the summary of this revision. (Show Details)

This should also be ready now that https://reviews.llvm.org/D85802 landed, unless we don't want to submit this *right* now so the clang builders don't build these multilibs that won't be used yet?

This should also be ready now that https://reviews.llvm.org/D85802 landed, unless we don't want to submit this *right* now so the clang builders don't build these multilibs that won't be used yet?

This change implement a slightly different approach from what we discussed, which is providing an Itanium-compatible (that is -fc++abi=itanium) multilib for compatibility with other compilers, and then enabling relative vtables by default. Unless there's a strong reason not to take that approach, that's the direction I'd prefer.

This change implement a slightly different approach from what we discussed, which is providing an Itanium-compatible (that is -fc++abi=itanium) multilib for compatibility with other compilers, and then enabling relative vtables by default. Unless there's a strong reason not to take that approach, that's the direction I'd prefer.

Ah, yeah I just forgot about that. Will update accoringly.

leonardchan edited the summary of this revision. (Show Details)

Updated to use the -fexperimental-relative-c++-ab-vtables flag now that D85802 was reverted. This will be used for the purpose of testing the relative vtables ABI in Fuchsia CQ builders to ensure all tests are run, accounting for flakes. The end goal will involve not having a relative vtables multilib, but instead making it the default for the fuchsia ABI, and instead having a separate Itanium multilib for supporting GCC.

*ping* any more comments on this patch?

phosek accepted this revision.Thu, Nov 19, 11:10 AM

LGTM

This revision is now accepted and ready to land.Thu, Nov 19, 11:10 AM