Page MenuHomePhabricator

[Clang][Test] add specific targets for OSX failures
AbandonedPublic

Authored by nickdesaulniers on Aug 7 2020, 4:01 PM.

Diff Detail

Event Timeline

nickdesaulniers created this revision.Aug 7 2020, 4:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 7 2020, 4:01 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
nickdesaulniers requested review of this revision.Aug 7 2020, 4:01 PM
aprantl added a subscriber: aprantl.Aug 7 2020, 4:07 PM

I think this could be problematic when building a Clang without an X86 target, unless you also mark X86 REQUIRED (at least in the CodeGen tests). Would using cc1 and hardcoding --debug-info-kind=limited (or something like that) work, too?

nickdesaulniers planned changes to this revision.Aug 7 2020, 4:12 PM
dblaikie added inline comments.Aug 7 2020, 10:09 PM
clang/test/CodeGen/debug-info-unused-types.cpp
1–5

Oh, sorry I didn't notice this in the original review - tests outside of test/Driver should only use %clang_cc1, rather than testing through the driver. Could you update this test and the C test to use %clang_cc1?

& why did this need a specific target triple? What did that change in the output?

It looks like maybe the/a bug is that the RETTYPES check has a hardcoded value in it (!5, in this test, !17 in the C test) - those should be removed, replaced with {{![0-9]*}} for instance. That might make these tests work without a specific triple, which would get us some more test coverage.