This is an archive of the discontinued LLVM Phabricator instance.

Paths

[Tsan] Fix the mmap_large.cc test to build on FreeBSD
ClosedPublic

Authored by kutuzov.viktor.84 on Mar 23 2015, 7:32 AM.

Reviewers

Commits

kutuzov.viktor.84 retitled this revision from to [Tsan] Fix the mmap_large.cc test to build on FreeBSD.

kutuzov.viktor.84 updated this object.

kutuzov.viktor.84 edited the test plan for this revision. (Show Details)

kutuzov.viktor.84 added a subscriber: Unknown Object (MLST).

LGTM

I think #if defined(__FreeBSD__) && !defined(MAP_NORESERVE) would also be fine.

This revision is now accepted and ready to land.Mar 23 2015, 8:04 AM

LGTM

This revision was automatically updated to reflect the committed changes.

Path

Size

test/

tsan/

7 lines

	// RUN: %clang_tsan -O1 %s -o %t && %run %t 2>&1 \| FileCheck %s			// RUN: %clang_tsan -O1 %s -o %t && %run %t 2>&1 \| FileCheck %s
	#include <stdint.h>			#include <stdint.h>
	#include <stdio.h>			#include <stdio.h>
	#include <errno.h>			#include <errno.h>
	#include <sys/mman.h>			#include <sys/mman.h>

				#if defined(__FreeBSD__)
				// The MAP_NORESERVE define has been removed in FreeBSD 11.x, and even before
				// that, it was never implemented. So just define it to zero.
				#undef MAP_NORESERVE
				#define MAP_NORESERVE 0
				#endif

	int main() {			int main() {
	#ifdef __x86_64__			#ifdef __x86_64__
	const size_t kLog2Size = 39;			const size_t kLog2Size = 39;
	#elif defined(__mips64)			#elif defined(__mips64)
	const size_t kLog2Size = 32;			const size_t kLog2Size = 32;
	#endif			#endif
	const uintptr_t kLocation = 0x40ULL << kLog2Size;			const uintptr_t kLocation = 0x40ULL << kLog2Size;
	void *p = mmap(			void *p = mmap(
	Show All 10 Lines