Have the linker find libc++ on its search path by adding -lc++.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
clang/lib/Driver/ToolChains/AIX.cpp | ||
---|---|---|
210 | Should there be a test for the error message? | |
211 | I suggest using return inside the switch and having llvm_unreachable after the switch if the switch is expected to handle all of the possible cases. | |
clang/test/Driver/aix-ld.c | ||
19 | Should there be tests that the C++ library is not included when linking with a C invocation? |
LGTM with minor edits.
clang/lib/Driver/ToolChains/AIX.cpp | ||
---|---|---|
213 | Minor nit: Follow normal capitalization rules when not formatting for a user-facing error message that falls under https://llvm.org/docs/CodingStandards.html#id15. | |
clang/test/Driver/aix-ld.c | ||
336–338 | Minor nit: We align the options to a utility on later lines with the options to the utility on earlier lines. | |
343–345 |
Landed by commit: rGb129c9d81aff8ece71eb29df1e5f31136a48c040
(Sorry, I didn't properly align the tags in commit message and hence this revision was not automatically closed after landing to master. Will switch to Arc)
This is commonly added before -lc, etc. To be consistent with other targets, please switch the order of this block with the previous one.