This is an archive of the discontinued LLVM Phabricator instance.

Differential D85294

[dsymutil] Disable dsymutil/X86/reproducer.test on windows.
ClosedPublic

Authored by avl on Aug 5 2020, 4:47 AM.

Details

Reviewers
JDevlieghere
friss
Commits
rGc6eb76093c3b: [dsymutil] Disable dsymutil/X86/reproducer.test on windows.
Summary

The dsymutil/X86/reproducer.test test could create paths
longer than MAX_PATH:

C:\ps4-buildslave2\llvm-clang-x86_64-expensive-checks-win
\build\test\tools\dsymutil\X86\Output\reproducer.test.tmp.repro
\ps4-buildslave2\llvm-clang-x86_64-expensive-checks-win\build
\test\tools\dsymutil\X86\Output\reproducer.test.tmp\Inputs\
basic1.macho.x86_64.o

Disable this test on windows.

Diff Detail

Event Timeline

avl created this revision.Aug 5 2020, 4:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 5 2020, 4:47 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
avl requested review of this revision.Aug 5 2020, 4:47 AM
Harbormaster completed remote builds in B67078: Diff 283199.Aug 5 2020, 5:18 AM
JDevlieghere accepted this revision.Aug 5 2020, 3:15 PM
This revision is now accepted and ready to land.Aug 5 2020, 3:15 PM
This revision was landed with ongoing or failed builds.Aug 6 2020, 2:51 AM
Closed by commit rGc6eb76093c3b: [dsymutil] Disable dsymutil/X86/reproducer.test on windows. (authored by avl). · Explain Why
This revision was automatically updated to reflect the committed changes.
avl added a commit: rGc6eb76093c3b: [dsymutil] Disable dsymutil/X86/reproducer.test on windows..

Revision Contents

PathSize
llvm/
test/
tools/
dsymutil/
X86/
4 lines

Diff 283545

llvm/test/tools/dsymutil/X86/reproducer.test

# UNSUPPORTED: system-windows
# This test is unsupported on windows because it creates paths
# longer than MAX_PATH
# Recreate the folder structure in a temp directory we can remove later. # Recreate the folder structure in a temp directory we can remove later.
RUN: rm -rf %t RUN: rm -rf %t
RUN: mkdir -p %t/Inputs RUN: mkdir -p %t/Inputs
RUN: cp %p/../Inputs/basic.macho.x86_64 %t/Inputs RUN: cp %p/../Inputs/basic.macho.x86_64 %t/Inputs
RUN: cp %p/../Inputs/basic1.macho.x86_64.o %t/Inputs RUN: cp %p/../Inputs/basic1.macho.x86_64.o %t/Inputs
RUN: cp %p/../Inputs/basic2.macho.x86_64.o %t/Inputs RUN: cp %p/../Inputs/basic2.macho.x86_64.o %t/Inputs
RUN: cp %p/../Inputs/basic3.macho.x86_64.o %t/Inputs RUN: cp %p/../Inputs/basic3.macho.x86_64.o %t/Inputs
▲ Show 20 Lines • Show All 68 Lines • Show Last 20 Lines