Refactor: Simplify boolean expressions in ARM target

[LegalizeAdulthood]

Summary

Simplify boolean expressions using true and false with clang-tidy

[rengolin]

Looks good with the comment, thanks!

lib/Target/ARM/AsmParser/ARMAsmParser.cpp

5421

Nitpick, maybe keep the Mnemonic on the next line, so it continues to align with the others.

[LegalizeAdulthood]

Ran clang-format on modified function

lib/Target/ARM/AsmParser/ARMAsmParser.cpp

5421

Fixed; ran clang-format on the modified function.

[LegalizeAdulthood]

Can someone submit this for me please? I don't have commit access. Thanks.

[alexfh]

Committed revision 234901.

lib/Target/ARM/ARMSubtarget.cpp

void ARMSubtarget::initSubtargetFeatures(StringRef CPU, StringRef FS) {
   }
 
   // No v6M core supports unaligned memory access (v6M ARM ARM A3.2)
   if (isV6M())
     AllowsUnalignedMem = false;
 
   switch (IT) {
   case DefaultIT:
-    RestrictIT = hasV8Ops() ? true : false;
+    RestrictIT = hasV8Ops();
     break;
   case RestrictedIT:
     RestrictIT = true;
     break;
   case NoRestrictedIT:
     RestrictIT = false;
     break;
   }

lib/Target/ARM/AsmParser/ARMAsmParser.cpp

 
 /// \brief Given a canonical mnemonic, determine if the instruction ever allows
 /// inclusion of carry set or predication code operands.
 //
 // FIXME: It would be nice to autogen this.
 void ARMAsmParser::
 getMnemonicAcceptInfo(StringRef Mnemonic, StringRef FullInst,
                      bool &CanAcceptCarrySet, bool &CanAcceptPredicationCode) {
-  if (Mnemonic == "and" || Mnemonic == "lsl" || Mnemonic == "lsr" ||
+  CanAcceptCarrySet = Mnemonic == "and" || Mnemonic == "lsl" || Mnemonic == "lsr" ||
       Mnemonic == "rrx" || Mnemonic == "ror" || Mnemonic == "sub" ||
       Mnemonic == "add" || Mnemonic == "adc" ||
       Mnemonic == "mul" || Mnemonic == "bic" || Mnemonic == "asr" ||
       Mnemonic == "orr" || Mnemonic == "mvn" ||
       Mnemonic == "rsb" || Mnemonic == "rsc" || Mnemonic == "orn" ||
       Mnemonic == "sbc" || Mnemonic == "eor" || Mnemonic == "neg" ||
       Mnemonic == "vfm" || Mnemonic == "vfnm" ||
       (!isThumb() && (Mnemonic == "smull" || Mnemonic == "mov" ||
                       Mnemonic == "mla" || Mnemonic == "smlal" ||
-                      Mnemonic == "umlal" || Mnemonic == "umull"))) {
-    CanAcceptCarrySet = true;
-  } else
-    CanAcceptCarrySet = false;
+                      Mnemonic == "umlal" || Mnemonic == "umull"));
 
   if (Mnemonic == "bkpt" || Mnemonic == "cbnz" || Mnemonic == "setend" ||
       Mnemonic == "cps" ||  Mnemonic == "it" ||  Mnemonic == "cbz" ||
       Mnemonic == "trap" || Mnemonic == "hlt" || Mnemonic == "udf" ||
       Mnemonic.startswith("crc32") || Mnemonic.startswith("cps") ||
       Mnemonic.startswith("vsel") ||
       Mnemonic == "vmaxnm" || Mnemonic == "vminnm" || Mnemonic == "vcvta" ||
       Mnemonic == "vcvtn" || Mnemonic == "vcvtp" || Mnemonic == "vcvtm" ||