Refactor: Simplify boolean expressions in R600 target

[LegalizeAdulthood]

Summary

Simplify boolean expressions with true and false using clang-tidy

[• tstellarAMD]

LGTM.

[LegalizeAdulthood]

Can someone commit this for me, please? I do not have commit access. You can attribute it to Richard Thomson.

[dblaikie]

Sure thing - committed as r233020

lib/Target/R600/AMDILCFGStructurizer.cpp

 }
 
 DebugLoc AMDGPUCFGStructurizer::getLastDebugLocInBB(MachineBasicBlock *MBB) {
   //get DebugLoc from the first MachineBasicBlock instruction with debug info
   DebugLoc DL;
   for (MachineBasicBlock::iterator It = MBB->begin(); It != MBB->end();
       ++It) {
     MachineInstr *instr = &(*It);
-    if (instr->getDebugLoc().isUnknown() == false)
+    if (!instr->getDebugLoc().isUnknown())
       DL = instr->getDebugLoc();
   }
   return DL;
 }
 
 MachineInstr *AMDGPUCFGStructurizer::getNormalBlockBranchInstr(
     MachineBasicBlock *MBB) {
   MachineBasicBlock::reverse_iterator It = MBB->rbegin();
if (MI) {
     assert(isCondBranch(MI));
     MachineBasicBlock::iterator I = MI;
     MachineBasicBlock *TrueBranch = getTrueBranch(MI);
     int OldOpcode = MI->getOpcode();
     DebugLoc DL = MI->getDebugLoc();
 
     bool UseContinueLogical = ((&*ContingMBB->rbegin()) == MI);
 
-    if (UseContinueLogical == false) {
+    if (!UseContinueLogical) {
       int BranchOpcode =
           TrueBranch == ContMBB ? getBranchNzeroOpcode(OldOpcode) :
           getBranchZeroOpcode(OldOpcode);
       insertCondBranchBefore(I, BranchOpcode, DL);
       // insertEnd to ensure phi-moves, if exist, go before the continue-instr.
       insertInstrEnd(ContingMBB, AMDGPU::CONTINUE, DL);
       insertInstrEnd(ContingMBB, AMDGPU::ENDIF, DL);
     } else {