Based on http://reviews.llvm.org/D8504
Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
This looks OK, with one small clarification. (Feel free to commit with that change unless you disagree).
Tim.
lib/Target/ARM/ARMAsmPrinter.cpp | ||
---|---|---|
669 | I think this is a bit non-obvious. I grant that it's correct (and equivalent to !StringRef::startswith), but I think this looks too much like "if generic is in CPUString". I'd suggest an explicit comparison against 0, which might make people at least consider whether string::find returns an index and what it returns for failure. |
Comment Actions
- CPUString.find("generic") is replaced with more understandable construction
- The first revision was based not on trunk, but on patches, that are not yet approved. To be able to commit, definitions of "V8_1" subtarget feature added from http://reviews.llvm.org/D8503 (AArch64) and http://reviews.llvm.org/D8498 (ARM). Now the second revision is based on ToT.
Tim, would you please approve the second change?
I think this is a bit non-obvious. I grant that it's correct (and equivalent to !StringRef::startswith), but I think this looks too much like "if generic is in CPUString".
I'd suggest an explicit comparison against 0, which might make people at least consider whether string::find returns an index and what it returns for failure.