This is an archive of the discontinued LLVM Phabricator instance.

Differential D85022

Need to ensure the datalayout differs when using externref
AbandonedPublic

Authored by pmatos on Jul 31 2020, 4:43 AM.

Details

Reviewers
None
Summary

externref needs address space 256.

Diff Detail

Event Timeline

pmatos created this revision.Jul 31 2020, 4:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 31 2020, 4:43 AM
Herald added subscribers: cfe-commits, jgravelle-google, sbc100, dschuff. · View Herald Transcript
pmatos requested review of this revision.Jul 31 2020, 4:43 AM
Herald added a subscriber: aheejin. · View Herald TranscriptJul 31 2020, 4:43 AM
pmatos abandoned this revision.Jul 31 2020, 4:45 AM

Mistakingly created - this should have gone to D66035

Harbormaster completed remote builds in B66541: Diff 282191.Jul 31 2020, 5:11 AM

Revision Contents

PathSize
clang/
lib/
Basic/
Targets/
1 line

Diff 282191

clang/lib/Basic/Targets/WebAssembly.cpp

Show First 20 Lines • Show All 226 Lines • ▼ Show 20 Lines if (Feature == "+tail-call") {
continue; continue;
} }
if (Feature == "-tail-call") { if (Feature == "-tail-call") {
HasTailCall = false; HasTailCall = false;
continue; continue;
} }
if (Feature == "+reference-types") { if (Feature == "+reference-types") {
HasReferenceTypes = true; HasReferenceTypes = true;
resetDataLayout("e-m:e-p:32:32-i64:64-n32:64-S128-ni:256");
continue; continue;
} }
if (Feature == "-reference-types") { if (Feature == "-reference-types") {
HasReferenceTypes = false; HasReferenceTypes = false;
continue; continue;
} }
Diags.Report(diag::err_opt_not_valid_with_opt) Diags.Report(diag::err_opt_not_valid_with_opt)
Show All 22 Lines