This is an archive of the discontinued LLVM Phabricator instance.

Differential D84756

[Mingw] Don't export symbols from profile generate.
ClosedPublic

Authored by SquallATF on Jul 28 2020, 7:38 AM.

Details

Reviewers
mstorsjo
Commits
rGda324f990463: [LLD] [Mingw] Don't export symbols from profile generate

Diff Detail

Event Timeline

SquallATF created this revision.Jul 28 2020, 7:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 28 2020, 7:38 AM
Herald added subscribers: llvm-commits, mstorsjo. · View Herald Transcript
SquallATF requested review of this revision.Jul 28 2020, 7:38 AM
Harbormaster completed remote builds in B66024: Diff 281231.Jul 28 2020, 8:23 AM
mstorsjo accepted this revision.Jul 28 2020, 12:45 PM

LGTM

This revision is now accepted and ready to land.Jul 28 2020, 12:45 PM
Closed by commit rGda324f990463: [LLD] [Mingw] Don't export symbols from profile generate (authored by SquallATF, committed by mstorsjo). · Explain WhyJul 30 2020, 1:35 PM
This revision was automatically updated to reflect the committed changes.
mstorsjo added a commit: rGda324f990463: [LLD] [Mingw] Don't export symbols from profile generate.
mstorsjo added a subscriber: hans.Jul 30 2020, 1:41 PM

@hans - @SquallATF wants this one backported to the 11.x release branch, which I think is reasonable.

hans added a comment.Jul 31 2020, 10:58 AM
In D84756#2185834, @mstorsjo wrote:

@hans - @SquallATF wants this one backported to the 11.x release branch, which I think is reasonable.

Pushed as 821e924f0d3e0fc9b5991a126fd094eec12bd535. Thanks!

Revision Contents

PathSize
lld/
COFF/
9 lines

Diff 282032

lld/COFF/MinGW.cpp

Show All 28 Lines excludeLibs = {
"libsupc++", "libsupc++",
"libobjc", "libobjc",
"libgcj", "libgcj",
"libclang_rt.builtins", "libclang_rt.builtins",
"libclang_rt.builtins-aarch64", "libclang_rt.builtins-aarch64",
"libclang_rt.builtins-arm", "libclang_rt.builtins-arm",
"libclang_rt.builtins-i386", "libclang_rt.builtins-i386",
"libclang_rt.builtins-x86_64", "libclang_rt.builtins-x86_64",
"libclang_rt.profile",
"libclang_rt.profile-aarch64",
"libclang_rt.profile-arm",
"libclang_rt.profile-i386",
"libclang_rt.profile-x86_64",
"libc++", "libc++",
"libc++abi", "libc++abi",
"libunwind", "libunwind",
"libmsvcrt", "libmsvcrt",
"libucrtbase", "libucrtbase",
}; };
excludeObjects = { excludeObjects = {
"crt0.o", "crt1.o", "crt1u.o", "crt2.o", "crt2u.o", "dllcrt1.o", "crt0.o", "crt1.o", "crt1u.o", "crt2.o", "crt2u.o", "dllcrt1.o",
"dllcrt2.o", "gcrt0.o", "gcrt1.o", "gcrt2.o", "crtbegin.o", "crtend.o", "dllcrt2.o", "gcrt0.o", "gcrt1.o", "gcrt2.o", "crtbegin.o", "crtend.o",
}; };
excludeSymbolPrefixes = { excludeSymbolPrefixes = {
// Import symbols // Import symbols
"__imp_", "__imp_",
"__IMPORT_DESCRIPTOR_", "__IMPORT_DESCRIPTOR_",
// Extra import symbols from GNU import libraries // Extra import symbols from GNU import libraries
"__nm_", "__nm_",
// C++ symbols // C++ symbols
"__rtti_", "__rtti_",
"__builtin_", "__builtin_",
// Artificial symbols such as .refptr // Artificial symbols such as .refptr
".", ".",
// profile generate symbols
"__profc_",
"__profd_",
"__profvp_",
}; };
excludeSymbolSuffixes = { excludeSymbolSuffixes = {
"_iname", "_iname",
"_NULL_THUNK_DATA", "_NULL_THUNK_DATA",
}; };
if (config->machine == I386) { if (config->machine == I386) {
▲ Show 20 Lines • Show All 99 Lines • Show Last 20 Lines