This is an archive of the discontinued LLVM Phabricator instance.

Differential D84749

[ELF][test] Add test coverage of `__real_` to wrap-plt.s
ClosedPublic

Authored by andrewng on Jul 28 2020, 6:41 AM.

Details

Reviewers
grimar
ruiu
MaskRay
• espindola
Commits
rG8725a49409c4: [ELF][test] Add test coverage of `__real_` to wrap-plt.s

Diff Detail

Event Timeline

andrewng created this revision.Jul 28 2020, 6:41 AM
Herald added a reviewer: • espindola. · View Herald TranscriptJul 28 2020, 6:41 AM
Herald added a subscriber: emaste. · View Herald Transcript
andrewng requested review of this revision.Jul 28 2020, 6:41 AM
grimar accepted this revision.Jul 28 2020, 6:43 AM

LGTM

This revision is now accepted and ready to land.Jul 28 2020, 6:43 AM
MaskRay accepted this revision.Jul 28 2020, 10:01 PM

Thanks!

Closed by commit rG8725a49409c4: [ELF][test] Add test coverage of `__real_` to wrap-plt.s (authored by andrewng). · Explain WhyJul 29 2020, 6:12 AM
This revision was automatically updated to reflect the committed changes.
andrewng added a commit: rG8725a49409c4: [ELF][test] Add test coverage of `__real_` to wrap-plt.s.
Herald added a project: Restricted Project. · View Herald TranscriptJul 29 2020, 6:12 AM

Revision Contents

PathSize
lld/
test/
ELF/
3 lines

Diff 281213

lld/test/ELF/wrap-plt.s

// REQUIRES: x86 // REQUIRES: x86
/// Test we correctly wrap PLT calls. /// Test we correctly wrap PLT calls.
// RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t // RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t
// RUN: ld.lld -o %t2 %t -wrap foo -shared // RUN: ld.lld -o %t2 %t -wrap foo -shared
// RUN: llvm-readobj -S -r %t2 | FileCheck %s // RUN: llvm-readobj -S -r %t2 | FileCheck %s
// RUN: llvm-objdump -d %t2 | FileCheck --check-prefix=DISASM %s // RUN: llvm-objdump -d %t2 | FileCheck --check-prefix=DISASM %s
// CHECK: Relocations [ // CHECK: Relocations [
// CHECK-NEXT: Section ({{.*}}) .rela.plt { // CHECK-NEXT: Section ({{.*}}) .rela.plt {
// CHECK-NEXT: R_X86_64_JUMP_SLOT __wrap_foo 0x0 // CHECK-NEXT: R_X86_64_JUMP_SLOT __wrap_foo 0x0
// CHECK-NEXT: R_X86_64_JUMP_SLOT foo 0x0
// CHECK-NEXT: R_X86_64_JUMP_SLOT _start 0x0 // CHECK-NEXT: R_X86_64_JUMP_SLOT _start 0x0
// CHECK-NEXT: } // CHECK-NEXT: }
// CHECK-NEXT: ] // CHECK-NEXT: ]
// DISASM: <_start>: // DISASM: <_start>:
// DISASM-NEXT: jmp {{.*}} <__wrap_foo@plt> // DISASM-NEXT: jmp {{.*}} <__wrap_foo@plt>
// DISASM-NEXT: jmp {{.*}} <__wrap_foo@plt> // DISASM-NEXT: jmp {{.*}} <__wrap_foo@plt>
// DISASM-NEXT: jmp {{.*}} <foo@plt>
// DISASM-NEXT: jmp {{.*}} <_start@plt> // DISASM-NEXT: jmp {{.*}} <_start@plt>
.global foo .global foo
foo: foo:
nop nop
.global __wrap_foo .global __wrap_foo
__wrap_foo: __wrap_foo:
nop nop
.global _start .global _start
_start: _start:
jmp foo@plt jmp foo@plt
jmp __wrap_foo@plt jmp __wrap_foo@plt
jmp __real_foo@plt
jmp _start@plt jmp _start@plt