This is an archive of the discontinued LLVM Phabricator instance.

[NFC] [MIR] Document the reg state flags
ClosedPublic

Authored by djtodoro on Jul 27 2020, 3:58 AM.

Details

Summary

This patch adds documentation for the RegState enumeration.

Diff Detail

Event Timeline

djtodoro created this revision.Jul 27 2020, 3:58 AM
aprantl added inline comments.Jul 27 2020, 1:35 PM
llvm/include/llvm/CodeGen/MachineInstrBuilder.h
45

This is personal preference, but IMO, once comments span more than one line the

enum {
  /// Register definition.
  Define = 0x2,        
  ///Not emitted register (e.g. carry, or
  ///temporary)
  Implicit = 0x4,

format is less confusing to read.

djtodoro added inline comments.Jul 27 2020, 11:27 PM
llvm/include/llvm/CodeGen/MachineInstrBuilder.h
45

It makes sense :) Thanks!

djtodoro updated this revision to Diff 281118.Jul 27 2020, 11:28 PM
  • refactor the comments
djtodoro updated this revision to Diff 281128.Jul 28 2020, 12:12 AM
  • additional formatting
aprantl accepted this revision.Jul 31 2020, 5:26 PM
This revision is now accepted and ready to land.Jul 31 2020, 5:26 PM
This revision was automatically updated to reflect the committed changes.