This is an archive of the discontinued LLVM Phabricator instance.

Differential D84586

GlobalISel: Don't assert on operations with no type indices
ClosedPublic

Authored by arsenm on Jul 25 2020, 7:32 AM.

Details

Reviewers
aemerson
paquette
aditya_nandakumar
Summary

Fix not marking G_FENCE as legal on AMDGPU This was apparently
defaulting to legal using the "legacy" rules, whatever those are.

Diff Detail

Event Timeline

arsenm created this revision.Jul 25 2020, 7:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 25 2020, 7:32 AM
Herald added subscribers: kerbowa, jfb, hiraditya and 5 others. · View Herald Transcript
paquette accepted this revision.Jul 28 2020, 9:20 AM

LGTM

This revision is now accepted and ready to land.Jul 28 2020, 9:20 AM
arsenm closed this revision.Jul 28 2020, 1:50 PM

e87356b4981bb0b504c106fd70fbde31e84447e6

Revision Contents

PathSize
llvm/
lib/
CodeGen/
GlobalISel/
3 lines
Target/
AMDGPU/
3 lines

Diff 280678

llvm/lib/CodeGen/GlobalISel/LegalizerInfo.cpp

Show First 20 Lines • Show All 99 Lines • ▼ Show 20 Linesraw_ostream &LegalityQuery::print(raw_ostream &OS) const {
return OS; return OS;
} }
#ifndef NDEBUG #ifndef NDEBUG
// Make sure the rule won't (trivially) loop forever. // Make sure the rule won't (trivially) loop forever.
static bool hasNoSimpleLoops(const LegalizeRule &Rule, const LegalityQuery &Q, static bool hasNoSimpleLoops(const LegalizeRule &Rule, const LegalityQuery &Q,
const std::pair<unsigned, LLT> &Mutation) { const std::pair<unsigned, LLT> &Mutation) {
switch (Rule.getAction()) { switch (Rule.getAction()) {
case Legal:
case Custom: case Custom:
case Lower: case Lower:
case MoreElements: case MoreElements:
case FewerElements: case FewerElements:
break; break;
default: default:
return Q.Types[Mutation.first] != Mutation.second; return Q.Types[Mutation.first] != Mutation.second;
} }
return true; return true;
} }
// Make sure the returned mutation makes sense for the match type. // Make sure the returned mutation makes sense for the match type.
static bool mutationIsSane(const LegalizeRule &Rule, static bool mutationIsSane(const LegalizeRule &Rule,
const LegalityQuery &Q, const LegalityQuery &Q,
std::pair<unsigned, LLT> Mutation) { std::pair<unsigned, LLT> Mutation) {
// If the user wants a custom mutation, then we can't really say much about // If the user wants a custom mutation, then we can't really say much about
// it. Return true, and trust that they're doing the right thing. // it. Return true, and trust that they're doing the right thing.
if (Rule.getAction() == Custom) if (Rule.getAction() == Custom || Rule.getAction() == Legal)
return true; return true;
const unsigned TypeIdx = Mutation.first; const unsigned TypeIdx = Mutation.first;
const LLT OldTy = Q.Types[TypeIdx]; const LLT OldTy = Q.Types[TypeIdx];
const LLT NewTy = Mutation.second; const LLT NewTy = Mutation.second;
switch (Rule.getAction()) { switch (Rule.getAction()) {
case FewerElements: case FewerElements:
▲ Show 20 Lines • Show All 615 Lines • Show Last 20 Lines

llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp

Show First 20 Lines • Show All 1,517 Lines • ▼ Show 20 Lines
getActionDefinitionsBuilder(G_FSHR) getActionDefinitionsBuilder(G_FSHR)
.legalFor({{S32, S32}}) .legalFor({{S32, S32}})
.scalarize(0) .scalarize(0)
.lower(); .lower();
getActionDefinitionsBuilder(G_READCYCLECOUNTER) getActionDefinitionsBuilder(G_READCYCLECOUNTER)
.legalFor({S64}); .legalFor({S64});
getActionDefinitionsBuilder(G_FENCE)
.alwaysLegal();
getActionDefinitionsBuilder({ getActionDefinitionsBuilder({
// TODO: Verify V_BFI_B32 is generated from expanded bit ops // TODO: Verify V_BFI_B32 is generated from expanded bit ops
G_FCOPYSIGN, G_FCOPYSIGN,
G_ATOMIC_CMPXCHG_WITH_SUCCESS, G_ATOMIC_CMPXCHG_WITH_SUCCESS,
G_ATOMICRMW_NAND, G_ATOMICRMW_NAND,
G_ATOMICRMW_FSUB, G_ATOMICRMW_FSUB,
G_READ_REGISTER, G_READ_REGISTER,
▲ Show 20 Lines • Show All 2,906 Lines • Show Last 20 Lines