This is an archive of the discontinued LLVM Phabricator instance.

Differential D84484

[MLIR] Missing line breaks in MLIR Language Reference
ClosedPublic

Authored by rniczh on Jul 23 2020, 7:51 PM.

Details

Reviewers
mehdi_amini
Commits
rG75eb06f7535e: [MLIR] Missing line breaks in MLIR Language Reference
Summary

Missing line breaks in the example under Codegen of Unranked Memref section.

Diff Detail

Event Timeline

rniczh created this revision.Jul 23 2020, 7:51 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 23 2020, 7:51 PM
Herald added subscribers: msifontes, jurahul, Kayjukh and 14 others. · View Herald Transcript
Harbormaster completed remote builds in B65486: Diff 280319.Jul 23 2020, 8:07 PM
mehdi_amini accepted this revision.Jul 23 2020, 8:24 PM
This revision is now accepted and ready to land.Jul 23 2020, 8:24 PM
rniczh added a comment.Jul 23 2020, 10:00 PM

I don't have the commit access, can you commit for me? Thanks.

Name: H.-S. Zheng
Email: hszheng@cs.nctu.edu.tw

Closed by commit rG75eb06f7535e: [MLIR] Missing line breaks in MLIR Language Reference (authored by rniczh, committed by mehdi_amini). · Explain WhyJul 23 2020, 10:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
mlir/
docs/
7 lines

Diff 280325

mlir/docs/LangRef.md

Show First 20 Lines • Show All 974 Lines • ▼ Show 20 Lines
exposed to codegen but one may query the rank of an unranked memref (a special exposed to codegen but one may query the rank of an unranked memref (a special
op will be needed for this purpose) and perform a switch and cast to a ranked op will be needed for this purpose) and perform a switch and cast to a ranked
memref as a prerequisite to codegen. memref as a prerequisite to codegen.
Example: Example:
```mlir ```mlir
// With static ranks, we need a function for each possible argument type // With static ranks, we need a function for each possible argument type
%A = alloc() : memref<16x32xf32> %B = alloc() : %A = alloc() : memref<16x32xf32>
memref<16x32x64xf32> call @helper_2D(%A) : (memref<16x32xf32>)->() call %B = alloc() : memref<16x32x64xf32>
@helper_3D(%B) : (memref<16x32x64xf32>)->() call @helper_2D(%A) : (memref<16x32xf32>)->()
call @helper_3D(%B) : (memref<16x32x64xf32>)->()
// With unknown rank, the functions can be unified under one unranked type // With unknown rank, the functions can be unified under one unranked type
%A = alloc() : memref<16x32xf32> %A = alloc() : memref<16x32xf32>
%B = alloc() : memref<16x32x64xf32> %B = alloc() : memref<16x32x64xf32>
// Remove rank info // Remove rank info
%A_u = memref_cast %A : memref<16x32xf32> -> memref<*xf32> %A_u = memref_cast %A : memref<16x32xf32> -> memref<*xf32>
%B_u = memref_cast %B : memref<16x32x64xf32> -> memref<*xf32> %B_u = memref_cast %B : memref<16x32x64xf32> -> memref<*xf32>
// call same function with dynamic ranks // call same function with dynamic ranks
▲ Show 20 Lines • Show All 674 Lines • Show Last 20 Lines