Page MenuHomePhabricator

[libcxx] Adjust trivial_abi tests for C++03 and C++11 testing
ClosedPublic

Authored by miyuki on Jul 23 2020, 4:58 AM.

Details

Summary

This change replaces std::make_unique with manual construction of
std::unique_ptr to make the tests compatible with C++11
(std::make_unique is a C++14 feature).

libc++ supports std::unique_ptr and std::shared_ptr even in C++03 but
with some limitations: unique_ptr_array.pass.cpp and
shared_ptr_arg.pass.cpp fail to compile in C++03 mode and need to be
disabled.

Diff Detail

Event Timeline

miyuki created this revision.Jul 23 2020, 4:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 23 2020, 4:58 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
miyuki edited the summary of this revision. (Show Details)Jul 23 2020, 4:59 AM
ldionne accepted this revision.Jul 23 2020, 6:15 AM
This revision is now accepted and ready to land.Jul 23 2020, 6:15 AM
This revision was automatically updated to reflect the committed changes.