This is an archive of the discontinued LLVM Phabricator instance.

[libc] Add implementations of fmax, fmaxf, and fmaxl.
ClosedPublic

Authored by lntue on Jul 22 2020, 11:09 PM.

Details

Summary

Add implementations of fmax, fmaxf, and fmaxl.

Diff Detail

Event Timeline

lntue created this revision.Jul 22 2020, 11:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 22 2020, 11:09 PM
sivachandra accepted this revision.Jul 23 2020, 11:16 AM
sivachandra added inline comments.
libc/src/math/fmaxf.cpp
19

New line?

libc/test/src/math/fmax_test.cpp
9

Do we need this? Looks like they are present in the fmin tests as well. You can take them out in a separate obvious patch if they are not required.

This revision is now accepted and ready to land.Jul 23 2020, 11:16 AM
lntue updated this revision to Diff 280219.Jul 23 2020, 12:13 PM

[libc] Add implementations of fmax, fmaxf, and fmaxl.

lntue marked 2 inline comments as done.Jul 23 2020, 12:13 PM
This revision was automatically updated to reflect the committed changes.