Differential D84385

[libc] Add implementations of fmax, fmaxf, and fmaxl.
ClosedPublic
Actions

Authored by lntue on Jul 22 2020, 11:09 PM.

Details

Reviewers

sivachandra

Commits

rG4096088e1941: [libc] Add implementations of fmax, fmaxf, and fmaxl.

Summary

Add implementations of fmax, fmaxf, and fmaxl.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

lntue created this revision.Jul 22 2020, 11:09 PM

Herald added a project: Restricted Project. · View Herald TranscriptJul 22 2020, 11:09 PM

Herald added subscribers: ecnelises, tschuett, mgorny. · View Herald Transcript

Harbormaster failed remote builds in B65335: Diff 280033!Jul 22 2020, 11:53 PM

sivachandra accepted this revision.Jul 23 2020, 11:16 AM

sivachandra added inline comments.

libc/src/math/fmaxf.cpp
19	New line?
libc/test/src/math/fmax_test.cpp
10	Do we need this? Looks like they are present in the fmin tests as well. You can take them out in a separate obvious patch if they are not required.

This revision is now accepted and ready to land.Jul 23 2020, 11:16 AM

[libc] Add implementations of fmax, fmaxf, and fmaxl.

lntue marked 2 inline comments as done.Jul 23 2020, 12:13 PM

Closed by commit rG4096088e1941: [libc] Add implementations of fmax, fmaxf, and fmaxl. (authored by lntue). · Explain WhyJul 23 2020, 12:24 PM

This revision was automatically updated to reflect the committed changes.

Harbormaster failed remote builds in B65435: Diff 280219!Jul 23 2020, 12:45 PM

Revision Contents
Changeset List

Path

Size

libc/

config/

linux/

aarch64/

entrypoints.txt

3 lines

api.td

3 lines

x86_64/

entrypoints.txt

3 lines

spec/

stdc.td

4 lines

src/

math/

36 lines

18 lines

18 lines

18 lines

18 lines

18 lines

18 lines

test/

src/

math/

38 lines

73 lines

73 lines

73 lines

utils/

FPUtil/

BasicOperations.h

19 lines

Diff 280222

View Options

libc/config/linux/aarch64/entrypoints.txt

View Options

libc/config/linux/api.td

View Options

libc/config/linux/x86_64/entrypoints.txt

View Options

libc/spec/stdc.td

View Options

libc/src/math/CMakeLists.txt

View Options

libc/src/math/fmax.h

View Options

libc/src/math/fmax.cpp

View Options

libc/src/math/fmaxf.h

View Options

libc/src/math/fmaxf.cpp

View Options

libc/src/math/fmaxl.h

View Options

libc/src/math/fmaxl.cpp

View Options

libc/test/src/math/CMakeLists.txt

View Options

libc/test/src/math/fmax_test.cpp

View Options

libc/test/src/math/fmaxf_test.cpp

View Options

libc/test/src/math/fmaxl_test.cpp

View Options

libc/utils/FPUtil/BasicOperations.h

[libc] Add implementations of fmax, fmaxf, and fmaxl.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 280222

libc/config/linux/aarch64/entrypoints.txt

libc/config/linux/api.td

libc/config/linux/x86_64/entrypoints.txt

libc/spec/stdc.td

libc/src/math/CMakeLists.txt

libc/src/math/fmax.h

libc/src/math/fmax.cpp

libc/src/math/fmaxf.h

libc/src/math/fmaxf.cpp

libc/src/math/fmaxl.h

libc/src/math/fmaxl.cpp

libc/test/src/math/CMakeLists.txt

libc/test/src/math/fmax_test.cpp

libc/test/src/math/fmaxf_test.cpp

libc/test/src/math/fmaxl_test.cpp

libc/utils/FPUtil/BasicOperations.h

[libc] Add implementations of fmax, fmaxf, and fmaxl.
ClosedPublic
Actions

Revision Contents
Changeset List