Page MenuHomePhabricator

[WebAssembly] Fix store_unfolded_offset tests in simd-offset.ll
ClosedPublic

Authored by tlively on Jul 22 2020, 3:29 PM.

Details

Summary

These tests were previously duplicates of other tests rather than
testing their intended pattern.

Diff Detail

Event Timeline

tlively created this revision.Jul 22 2020, 3:29 PM

They seem to have been written that way because negative offsets aren't folded? What does it mean that they are duplicates of other patterns?

They seem to have been written that way because negative offsets aren't folded? What does it mean that they are duplicates of other patterns?

Sorry, I could have been more clear. The old bodies of the store_with_unfolded_offset tests were the same as the bodies of the store_with_unfolded_gep_negative_offset tests. This was probably a copy-paste error when I first created this file from offset.ll.

aheejin accepted this revision.Jul 23 2020, 3:32 PM

Aha I see. Thanks.

This revision is now accepted and ready to land.Jul 23 2020, 3:32 PM
This revision was automatically updated to reflect the committed changes.