Page MenuHomePhabricator

[PowerPC][Power10] Fix the Test LSB by Byte (xvtlsbb) Builtins Implementation
ClosedPublic

Authored by amyk on Jul 21 2020, 8:43 PM.

Details

Summary

The implementation of the xvtlsbb builtins/intrinsics were not correct as the intrinsics previously
used i1 as an argument type. This patch changes the i1 argument type used in these intrinsics
to be i32 instead, as having the second as an i1 can lead to issues in the backend.

Diff Detail

Event Timeline

amyk created this revision.Jul 21 2020, 8:43 PM
rzurob accepted this revision.Jul 22 2020, 1:18 AM

LGTM

This revision is now accepted and ready to land.Jul 22 2020, 1:18 AM
nemanjai accepted this revision.Jul 22 2020, 2:08 AM

LGTM. The test case addition can be done on the commit.

llvm/test/CodeGen/PowerPC/builtins-ppc-p10vsx.ll
2

Since the issue was discovered when compiling with -O0, can you please add a RUN line with -O0 to this test case?

This revision was automatically updated to reflect the committed changes.