[compiler-rt][test][profile] Fix missing include

[jroelofs]

Summary

... on systems where wait() isn't one of the declarations transitively included via unistd.h.

[MaskRay]

compiler-rt/test/profile/Posix/gcov-fork.c

14

No need for #if

sys/wait.h is specified by POSIX.

[jroelofs]

compiler-rt/test/profile/Posix/gcov-fork.c

14

Thanks. I wasn't sure.

[jroelofs]

review feedback

[MaskRay]

LGTM. Thanks for fixing it!

... on systems where wait() isn't one of the declarations transitively included via unistd.h.

Hope you can just be more specific about this - on which particular system wait() isn't transitively included via unistd.h
It conveys more information and helps posterity when they are reading the log.

[MaskRay]

compiler-rt/test/profile/Posix/gcov-fork.c

13

Reorder the headers to pacify clang-format

[jroelofs]

In D84207#2164611, @MaskRay wrote:

LGTM. Thanks for fixing it!

... on systems where wait() isn't one of the declarations transitively included via unistd.h.

Hope you can just be more specific about this - on which particular system wait() isn't transitively included via unistd.h
It conveys more information and helps posterity when they are reading the log.

I think this was just Darwin 10.15. Not sure why our public bots didn't catch it.

[thegameg]

In D84207#2164754, @jroelofs wrote:

Not sure why our public bots didn't catch it.

I also realized these tests don't run on green dragon. I'll look into setting that up.

compiler-rt/test/profile/Posix/gcov-fork.c

 /// A basic block with fork/exec* is split. .gcda is flushed immediately before
 /// fork/exec* so the lines before fork are counted once while succeeding
 /// lines are counted twice.
 // RUN: mkdir -p %t.d && cd %t.d
 // RUN: %clang --coverage %s -o %t
 // RUN: test -f gcov-fork.gcno
 
 // RUN: rm -f gcov-fork.gcda && %run %t
 // RUN: llvm-cov gcov -t gcov-fork.gcda | FileCheck %s
 
+#include <sys/wait.h>
 #include <unistd.h>
 
 void func1() {}                    // CHECK:      1: [[#@LINE]]:void func1()
 void func2() {}                    // CHECK-NEXT: 2: [[#@LINE]]:
 int main(void) {                   // CHECK-NEXT: 1: [[#@LINE]]:
   int status;                      // CHECK-NEXT: -: [[#@LINE]]:
   func1();                         // CHECK-NEXT: 1: [[#@LINE]]:
   pid_t pid = fork();              // CHECK-NEXT: 1: [[#@LINE]]:
   if (pid == -1) return 1;         // CHECK-NEXT: 2: [[#@LINE]]:
   if (pid)                         // CHECK-NEXT: 2: [[#@LINE]]:
     wait(&status);                 // CHECK-NEXT: 1: [[#@LINE]]:
   func2();                         // CHECK-NEXT: 2: [[#@LINE]]:
   return 0;                        // CHECK-NEXT: 2: [[#@LINE]]:
 }