Page MenuHomePhabricator

[libcxx][lit] Add a new executor to collect test binaries
Needs RevisionPublic

Authored by arichardson on Jul 17 2020, 9:46 AM.

Details

Reviewers
ldionne
wash
Group Reviewers
Restricted Project
Summary

I originally added this executor for the old test format to the CHERI fork
of libc++ to gather all test binaries in one directory. This change is a
simple port of the executor to the new format.

This is mostly useful for debugging and performing analysis on the compiled
binaries or copying them in bulk to a remote server. Using this executor
also helped me discover the bug fixed in https://reviews.llvm.org/D84040.

Diff Detail

Event Timeline

arichardson created this revision.Jul 17 2020, 9:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 17 2020, 9:46 AM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald Transcript
wash added a comment.EditedNov 9 2020, 11:04 AM

EDIT: Disregard my intention comment, Louis tells me that the setup for executors has changed a bit since we last pulled from trunk, and now they're all scripts like this. This looks fine, once the question I've asked below are resolved.

libcxx/utils/copy_files.py
22

Slight preference for this to be --codesign-identity, not --codesign_identity, to be consistent with the other ones.

wash requested changes to this revision.Nov 9 2020, 11:04 AM
This revision now requires changes to proceed.Nov 9 2020, 11:04 AM
wash added inline comments.Dec 2 2020, 10:27 AM
libcxx/utils/copy_files.py
41

Can we use a Python file API to validate that both of these directories exist and are writeable?

44

Why is this using subprocess instead of using a Python API for file copying? Using an actual file copy API would allow this script to remain platform independent and may help us handle errors better. For example, my org would love to use an executor like this on Windows.