This is an archive of the discontinued LLVM Phabricator instance.

[LiveVariables] Replace std::vector with SmallVector.
ClosedPublic

Authored by nadav on Jul 15 2020, 4:57 PM.

Download Raw Diff

Details

Reviewers

modocache
arsenm

Commits

rGa394aa1b974b: [LiveVariables] Replace std::vector with SmallVector.

Summary

Replace std::vector with SmallVector to reduce the number of mallocs. This method is frequently executed, and the number of elements in the vector is typically small.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed

	Time	Test
	510 ms	linux > MemorySanitizer-X86_64.MemorySanitizer-X86_64::Unknown Unit Message ("")
	270 ms	linux > MemorySanitizer-lld-X86_64.MemorySanitizer-lld-X86_64::Unknown Unit Message ("")
	530 ms	linux > SanitizerCommon-asan-x86_64-Linux.Linux::Unknown Unit Message ("")
	310 ms	linux > SanitizerCommon-lsan-x86_64-Linux.Linux::Unknown Unit Message ("")
	490 ms	linux > SanitizerCommon-msan-x86_64-Linux.Linux::Unknown Unit Message ("")
		View Full Test Results (9 Failed)

Event Timeline

nadav created this revision.Jul 15 2020, 4:57 PM

Herald added a project: Restricted Project. · View Herald TranscriptJul 15 2020, 4:57 PM

Herald added subscribers: llvm-commits, hiraditya. · View Herald Transcript

arsenm accepted this revision.Jul 15 2020, 5:07 PM

This revision is now accepted and ready to land.Jul 15 2020, 5:07 PM

Herald added a subscriber: wdng. · View Herald TranscriptJul 15 2020, 5:07 PM

Harbormaster failed remote builds in B64439: Diff 278337!Jul 15 2020, 5:27 PM

nadav mentioned this in D83849: [TableGen] Change std::vector to SmallVector.Jul 15 2020, 10:29 PM

nadav closed this revision.Jul 16 2020, 11:46 AM

nadav added a commit: rGa394aa1b974b: [LiveVariables] Replace std::vector with SmallVector..

Revision Contents

Path

Size

llvm/

include/

llvm/

CodeGen/

LiveVariables.h

5 lines

lib/

CodeGen/

LiveVariables.cpp

9 lines

Diff 278337

llvm/include/llvm/CodeGen/LiveVariables.h

Context not available.

	void MarkVirtRegAliveInBlock(VarInfo& VRInfo, MachineBasicBlock* DefBlock,	void MarkVirtRegAliveInBlock(VarInfo& VRInfo, MachineBasicBlock* DefBlock,
	MachineBasicBlock *BB);	MachineBasicBlock *BB);
	void MarkVirtRegAliveInBlock(VarInfo& VRInfo, MachineBasicBlock* DefBlock,	void MarkVirtRegAliveInBlock(VarInfo &VRInfo, MachineBasicBlock *DefBlock,
		Lint: Pre-merge checks Inline Actions clang-tidy: warning: invalid case style for function 'MarkVirtRegAliveInBlock' [readability-identifier-naming] not useful Lint: Pre-merge checks: clang-tidy: warning: invalid case style for function 'MarkVirtRegAliveInBlock' [readability…
	MachineBasicBlock *BB,	MachineBasicBlock *BB,
	std::vector<MachineBasicBlock*> &WorkList);	SmallVectorImpl<MachineBasicBlock *> &WorkList);

	void HandleVirtRegDef(unsigned reg, MachineInstr &MI);	void HandleVirtRegDef(unsigned reg, MachineInstr &MI);
	void HandleVirtRegUse(unsigned reg, MachineBasicBlock *MBB, MachineInstr &MI);	void HandleVirtRegUse(unsigned reg, MachineBasicBlock *MBB, MachineInstr &MI);

Context not available.

llvm/lib/CodeGen/LiveVariables.cpp

Context not available.
	return VirtRegInfo[RegIdx];	return VirtRegInfo[RegIdx];
	}	}

	void LiveVariables::MarkVirtRegAliveInBlock(VarInfo& VRInfo,	void LiveVariables::MarkVirtRegAliveInBlock(
		Lint: Pre-merge checks Inline Actions clang-tidy: warning: invalid case style for function 'MarkVirtRegAliveInBlock' [readability-identifier-naming] not useful Lint: Pre-merge checks: clang-tidy: warning: invalid case style for function 'MarkVirtRegAliveInBlock' [readability…
	MachineBasicBlock *DefBlock,	VarInfo &VRInfo, MachineBasicBlock DefBlock, MachineBasicBlock MBB,
	MachineBasicBlock *MBB,	SmallVectorImpl<MachineBasicBlock *> &WorkList) {
	std::vector<MachineBasicBlock*> &WorkList) {
	unsigned BBNum = MBB->getNumber();	unsigned BBNum = MBB->getNumber();

	// Check to see if this basic block is one of the killing blocks. If so,	// Check to see if this basic block is one of the killing blocks. If so,
Context not available.
	void LiveVariables::MarkVirtRegAliveInBlock(VarInfo &VRInfo,	void LiveVariables::MarkVirtRegAliveInBlock(VarInfo &VRInfo,
	MachineBasicBlock *DefBlock,	MachineBasicBlock *DefBlock,
	MachineBasicBlock *MBB) {	MachineBasicBlock *MBB) {
	std::vector<MachineBasicBlock*> WorkList;	SmallVector<MachineBasicBlock *, 16> WorkList;
	MarkVirtRegAliveInBlock(VRInfo, DefBlock, MBB, WorkList);	MarkVirtRegAliveInBlock(VRInfo, DefBlock, MBB, WorkList);

	while (!WorkList.empty()) {	while (!WorkList.empty()) {
Context not available.