Page MenuHomePhabricator

[libcxx] Move the libc++ header paths to the common location
AbandonedPublic

Authored by phosek on Jul 15 2020, 2:36 PM.

Details

Reviewers
ldionne
EricWF
Group Reviewers
Restricted Project
Summary

This change moves all libc++ header paths to the common location to
simplify future maintenance.

Diff Detail

Event Timeline

phosek created this revision.Jul 15 2020, 2:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 15 2020, 2:36 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne requested changes to this revision.Jul 16 2020, 8:45 AM
ldionne added inline comments.
libcxx/CMakeLists.txt
402

Can't we always do set(LIBCXX_HEADER_DIR "${CMAKE_BINARY_DIR}/something-private/include/c++/v1")? The place where we stage the headers is an implementation detail of the libc++ build anyway, so it shouldn't matter to any other project.

libcxx/include/CMakeLists.txt
250

Why don't we hardcode ${LIBCXX_INSTALL_HEADER_DIR} as include/c++/v1 here? I don't see the point in having this additional indirection.

This revision now requires changes to proceed.Jul 16 2020, 8:45 AM
phosek updated this revision to Diff 296816.Oct 7 2020, 3:18 PM
phosek added inline comments.
libcxx/include/CMakeLists.txt
250

See D89013 where I build the per-target config support on top of this patch.

phosek abandoned this revision.Mar 30 2021, 3:30 PM

Combined into D89013.