This is an archive of the discontinued LLVM Phabricator instance.

[mips][microMIPSr6] Implement initial mapping support
ClosedPublic

Authored by jkolek on Mar 17 2015, 11:50 AM.

Diff Detail

Event Timeline

jkolek updated this revision to Diff 22112.Mar 17 2015, 11:50 AM
jkolek retitled this revision from to [mips][microMIPSr6] Implement initial mapping support.
jkolek updated this object.
jkolek edited the test plan for this revision. (Show Details)
jkolek added reviewers: zoran.jovanovic, dsanders.
jkolek added subscribers: Unknown Object (MLST), petarj.
jkolek updated this revision to Diff 22648.Mar 25 2015, 7:29 AM
dsanders edited edge metadata.Apr 1 2015, 11:45 AM

I'm not very familiar with the mapping portion of microMIPS at the moment so I don't feel able to review this yet. All I know is that 'MM' does some magic that maps MIPS32r2 instructions to microMIPS instructions. Is there someone who is better able to review this? If not, I'll look into it and learn how this works.

lib/Target/Mips/MCTargetDesc/MipsMCCodeEmitter.cpp
182–185

As mentioned in D8386, I would expect isMicroMips(STI) to be true whenever isMicroMips32r6(STI) is.

jkolek updated this revision to Diff 23163.Apr 2 2015, 9:54 AM
jkolek edited edge metadata.
jkolek updated this revision to Diff 24011.Apr 20 2015, 4:06 AM
zoran.jovanovic accepted this revision.Apr 20 2015, 4:47 AM
zoran.jovanovic edited edge metadata.

LGTM.

lib/Target/Mips/MCTargetDesc/MipsMCCodeEmitter.cpp
183

Is it possible to introduce anf use isMips32r6 instead of isMicroMips32r6?

This revision is now accepted and ready to land.Apr 20 2015, 4:47 AM
This revision was automatically updated to reflect the committed changes.