This is an archive of the discontinued LLVM Phabricator instance.

Differential D83841

[argprom] Assessing impact of magic value MaxElements promoted on compiler performance
Needs ReviewPublic

Authored by teamiceberg on Jul 14 2020, 6:51 PM.

Details

Reviewers
jdoerfert
Summary

Our initial hypothesis is that changes to the magic value of (unsigned) MaxElements variable in ArgumentPromotion.cpp/ArgumentPromotion.h file can lead to changes in both compile time and run time compiler performance. To assess such changes, we extern declare a global variable (unsigned MaxElemsToPromote) in the IPO.h header file (default defined to 3 in ArgumentPromotion.h). Then, we supply different values for this global variable through an OPT command line flag (-argpromotion-max-elements-to-promote) bound to this global variable via the cl::opt interface. Initial analysis of compiler performance using the built-in test suite demonstrate some significant changes in compile time as well as run time, including beneficial changes(reductions in CT/RT) for some test cases.We are in the process of validating if these changes are real or just noise induced by other means. More experiments and sample runs need to be run, to be sure.
However, we are setting up this initial patch as a way to learn how to setup a pipeline to enable the use of global variables to simulate magic values. Also, we are designing a LIT test in llvm/tests folder to ensure that we submit a patch that demonstrates that the OPT flag works.
Regression Test Setup: /llvm/test/Transforms/ArgumentPromotion has 1 test written by me (fourmember-struct-promote.ll) which demonstrates the flag works successfully.
Regression Test success criteria: For aggregate arguments, such as structs, by design only a maximum of 3 members are promoted. However by introducing a custom OPT flag, we can set this number to different values to promote any number of an aggregate's arguments. For instance, the regression test file "fourmember-struct-promote.ll" has a four member struct passed by reference to a simple callee that sums the values of the members. The flag '-argpromotion-max-elements-to-promote' value has to be 0 or 4 (or higher) for all 4 members in the struct to be promoted. '0' defaults to 'always promote'. Supplying a value less than the number of members in the aggregate (in this case 4) halts promotion. The regression tests are designed to PASS when the FILECHECK tool pattern matches against an output that reflects all members have been promoted to "by value" for -argpromotion-max-elements-to-promote=[0 , 3, INT_MAX] cases respectively.

RESULTS:
fourmember-struct-promote.ll test PASSES according to success criteria defined above.
Therefore, we conclude that the --argpromotion-max-elements-to-promote user flag works correctly.

Now that we have this flag working correctly, users can test out the impact of argument promotion of elements of aggregates on compile time and run time performance.

Diff Detail

Unit TestsFailed

TimeTest
90 mswindows > LLVM.Transforms/ArgumentPromotion::Unknown Unit Message ("")

Event Timeline

teamiceberg created this revision.Jul 14 2020, 6:51 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 14 2020, 6:51 PM
Herald added subscribers: llvm-commits, hiraditya. · View Herald Transcript
jdoerfert added inline comments.Jul 14 2020, 7:02 PM
llvm/include/llvm/Transforms/IPO/ArgumentPromotion.h
19

The comment describes something unrelated.
Please rename the variable according to the naming convention.
A static variable definition in a header is problematic if the header is included more than once. Please use an extern variable declaration here and put the definition in the cpp file.

llvm/lib/Transforms/IPO/ArgumentPromotion.cpp
94

use a more expressive command line option name, e.g., argpromotion-max-argument-increase-per-promotion. Please update the description to describe what this actually controls. No need for value_desc.

1115

Please do not simply ignore the argument MaxElements that is passed here by the user of this function. If you want to modify the default for the old pass manager, which is using this function, please update the call site where there is a 3.

llvm/test/Transforms/ArgumentPromotion/fourmember-struct-promote-DEFAULT.ll
91

No need for the metadata and attributes at the end of this file, please remove.

llvm/test/Transforms/ArgumentPromotion/fourmember-struct-promote-INTMAX.ll
1

Please merge all three test files into one with 3 RUN lines and different check labels.

Harbormaster failed remote builds in B64274: Diff 278044!Jul 14 2020, 7:21 PM
jdoerfert added inline comments.Jul 14 2020, 7:38 PM
llvm/test/Transforms/ArgumentPromotion/fourmember-struct-promote-DEFAULT.ll
1

run mem2reg on the file *before* making it a test, not here.

teamiceberg updated this revision to Diff 278066.Jul 14 2020, 9:43 PM
teamiceberg marked an inline comment as done.
This comment was removed by teamiceberg.
Harbormaster failed remote builds in B64284: Diff 278066!Jul 14 2020, 9:44 PM
teamiceberg updated this revision to Diff 278067.Jul 14 2020, 10:00 PM

Diff Update V1 - All changes requested except consolidation of 3 RUNS in one file

Harbormaster failed remote builds in B64285: Diff 278067!Jul 14 2020, 10:00 PM
teamiceberg updated this revision to Diff 278096.Jul 15 2020, 12:41 AM
teamiceberg marked 5 inline comments as done.

Diff Update V2 - Consolidated 3 RUNS in one test file. Individual files deleted.

Harbormaster failed remote builds in B64307: Diff 278096!Jul 15 2020, 12:41 AM
ggeorgakoudis added a subscriber: ggeorgakoudis.Jul 15 2020, 8:33 AM
teamiceberg edited the summary of this revision. (Show Details)Jul 15 2020, 2:54 PM
teamiceberg updated this revision to Diff 278644.Jul 16 2020, 6:02 PM
teamiceberg marked an inline comment as done.

Re-basing against LLVM master

jdoerfert added inline comments.Jul 16 2020, 6:11 PM
llvm/include/llvm/Transforms/IPO.h
34 ↗(On Diff #278644)

No need to explain it is a global variable. Explain what the meaning is, e.g., what does the number indicate.

llvm/lib/Transforms/IPO/ArgumentPromotion.cpp
97

The comment is above is not necessary. The first sentence of the description is sufficient. The option should be hidden, compare other command line options please. The name of the variable is not proper.

101

Explain the meaning not where an extern definition is and that the value is by default three.

1115

Where is the change in the pass manager?

Harbormaster failed remote builds in B64620: Diff 278644!Jul 16 2020, 6:41 PM
teamiceberg updated this revision to Diff 279047.Jul 18 2020, 8:06 PM

All change requirements comments except Pass Manager change requirements addressed.I need more information to address Pass Manager CR.

Harbormaster failed remote builds in B64835: Diff 279047!Jul 18 2020, 8:16 PM
teamiceberg updated this revision to Diff 279048.Jul 18 2020, 8:34 PM
teamiceberg marked an inline comment as done.

Written text changes to patch's subject message. No source code changes.

Harbormaster completed remote builds in B64836: Diff 279048.Jul 18 2020, 9:10 PM

Revision Contents

PathSize
llvm/
include/
llvm/
Transforms/
IPO/
3 lines
lib/
Transforms/
IPO/
7 lines
test/
Transforms/
ArgumentPromotion/
91 lines
91 lines
91 lines

Diff 278044

llvm/include/llvm/Transforms/IPO/ArgumentPromotion.h

//===- ArgumentPromotion.h - Promote by-reference arguments -----*- C++ -*-===// //===- ArgumentPromotion.h - Promote by-reference arguments -----*- C++ -*-===//
Lint: Lint
Inline Actions

clang-format not found in user's PATH; not linting file.

Lint: Lint: clang-format not found in user's PATH; not linting file.
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#ifndef LLVM_TRANSFORMS_IPO_ARGUMENTPROMOTION_H #ifndef LLVM_TRANSFORMS_IPO_ARGUMENTPROMOTION_H
#define LLVM_TRANSFORMS_IPO_ARGUMENTPROMOTION_H #define LLVM_TRANSFORMS_IPO_ARGUMENTPROMOTION_H
#include "llvm/Analysis/CGSCCPassManager.h" #include "llvm/Analysis/CGSCCPassManager.h"
#include "llvm/Analysis/LazyCallGraph.h" #include "llvm/Analysis/LazyCallGraph.h"
#include "llvm/IR/PassManager.h" #include "llvm/IR/PassManager.h"
namespace llvm { namespace llvm {
//opt flag (if supplied) populates this Global Variable in the llvm namespace. Default value is set to 3, as was existing before.
//This global value can be changed via user input to set the maximum number of members that can be promoted with an aggregate.
static unsigned GL_NUMPROMARGS = 3;
jdoerfertUnsubmitted
Done
ReplyInline Actions

The comment describes something unrelated.
Please rename the variable according to the naming convention.
A static variable definition in a header is problematic if the header is included more than once. Please use an extern variable declaration here and put the definition in the cpp file.

jdoerfert: The comment describes something unrelated. Please rename the variable according to the naming…
class TargetTransformInfo; class TargetTransformInfo;
/// Argument promotion pass. /// Argument promotion pass.
/// ///
/// This pass walks the functions in each SCC and for each one tries to /// This pass walks the functions in each SCC and for each one tries to
/// transform it and all of its callers to replace indirect arguments with /// transform it and all of its callers to replace indirect arguments with
/// direct (by-value) arguments. /// direct (by-value) arguments.
class ArgumentPromotionPass : public PassInfoMixin<ArgumentPromotionPass> { class ArgumentPromotionPass : public PassInfoMixin<ArgumentPromotionPass> {
Show All 23 Lines

llvm/lib/Transforms/IPO/ArgumentPromotion.cpp

//===- ArgumentPromotion.cpp - Promote by-reference arguments -------------===// //===- ArgumentPromotion.cpp - Promote by-reference arguments -------------===//
Lint: Lint
Inline Actions

clang-format not found in user's PATH; not linting file.

Lint: Lint: clang-format not found in user's PATH; not linting file.
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
▲ Show 20 Lines • Show All 76 Lines • ▼ Show 20 Lines
#include <string> #include <string>
#include <utility> #include <utility>
#include <vector> #include <vector>
using namespace llvm; using namespace llvm;
#define DEBUG_TYPE "argpromotion" #define DEBUG_TYPE "argpromotion"
//opt flag to capture user supplied value for GV: GL_NUMPROMARGS
cl::opt<unsigned, true> argmax("numargspromoted", cl::desc("Specify number of args to promote"), cl::value_desc("numargs"), cl::location(llvm::GL_NUMPROMARGS));
jdoerfertUnsubmitted
Done
ReplyInline Actions

use a more expressive command line option name, e.g., argpromotion-max-argument-increase-per-promotion. Please update the description to describe what this actually controls. No need for value_desc.

jdoerfert: use a more expressive command line option name, e.g., `argpromotion-max-argument-increase-per…
STATISTIC(NumArgumentsPromoted, "Number of pointer arguments promoted"); STATISTIC(NumArgumentsPromoted, "Number of pointer arguments promoted");
STATISTIC(NumAggregatesPromoted, "Number of aggregate arguments promoted"); STATISTIC(NumAggregatesPromoted, "Number of aggregate arguments promoted");
jdoerfertUnsubmitted
Not Done
ReplyInline Actions

The comment is above is not necessary. The first sentence of the description is sufficient. The option should be hidden, compare other command line options please. The name of the variable is not proper.

jdoerfert: The comment is above is not necessary. The first sentence of the description is sufficient. The…
STATISTIC(NumByValArgsPromoted, "Number of byval arguments promoted"); STATISTIC(NumByValArgsPromoted, "Number of byval arguments promoted");
STATISTIC(NumArgumentsDead, "Number of dead pointer args eliminated"); STATISTIC(NumArgumentsDead, "Number of dead pointer args eliminated");
/// A vector used to hold the indices of a single GEP instruction /// A vector used to hold the indices of a single GEP instruction
jdoerfertUnsubmitted
Not Done
ReplyInline Actions

Explain the meaning not where an extern definition is and that the value is by default three.

jdoerfert: Explain the meaning not where an extern definition is and that the value is by default three.
using IndicesVector = std::vector<uint64_t>; using IndicesVector = std::vector<uint64_t>;
/// DoPromotion - This method actually performs the promotion of the specified /// DoPromotion - This method actually performs the promotion of the specified
/// arguments, and returns the new function. At this point, we know that it's /// arguments, and returns the new function. At this point, we know that it's
/// safe to do so. /// safe to do so.
static Function * static Function *
doPromotion(Function *F, SmallPtrSetImpl<Argument *> &ArgsToPromote, doPromotion(Function *F, SmallPtrSetImpl<Argument *> &ArgsToPromote,
SmallPtrSetImpl<Argument *> &ByValArgsToTransform, SmallPtrSetImpl<Argument *> &ByValArgsToTransform,
▲ Show 20 Lines • Show All 957 Lines • ▼ Show 20 Lines
namespace { namespace {
/// ArgPromotion - The 'by reference' to 'by value' argument promotion pass. /// ArgPromotion - The 'by reference' to 'by value' argument promotion pass.
struct ArgPromotion : public CallGraphSCCPass { struct ArgPromotion : public CallGraphSCCPass {
// Pass identification, replacement for typeid // Pass identification, replacement for typeid
static char ID; static char ID;
explicit ArgPromotion(unsigned MaxElements = 3) explicit ArgPromotion(unsigned MaxElements = GL_NUMPROMARGS)
: CallGraphSCCPass(ID), MaxElements(MaxElements) { : CallGraphSCCPass(ID), MaxElements(MaxElements) {
initializeArgPromotionPass(*PassRegistry::getPassRegistry()); initializeArgPromotionPass(*PassRegistry::getPassRegistry());
} }
void getAnalysisUsage(AnalysisUsage &AU) const override { void getAnalysisUsage(AnalysisUsage &AU) const override {
AU.addRequired<AssumptionCacheTracker>(); AU.addRequired<AssumptionCacheTracker>();
AU.addRequired<TargetLibraryInfoWrapperPass>(); AU.addRequired<TargetLibraryInfoWrapperPass>();
AU.addRequired<TargetTransformInfoWrapperPass>(); AU.addRequired<TargetTransformInfoWrapperPass>();
Show All 22 Lines
INITIALIZE_PASS_DEPENDENCY(AssumptionCacheTracker) INITIALIZE_PASS_DEPENDENCY(AssumptionCacheTracker)
INITIALIZE_PASS_DEPENDENCY(CallGraphWrapperPass) INITIALIZE_PASS_DEPENDENCY(CallGraphWrapperPass)
INITIALIZE_PASS_DEPENDENCY(TargetLibraryInfoWrapperPass) INITIALIZE_PASS_DEPENDENCY(TargetLibraryInfoWrapperPass)
INITIALIZE_PASS_DEPENDENCY(TargetTransformInfoWrapperPass) INITIALIZE_PASS_DEPENDENCY(TargetTransformInfoWrapperPass)
INITIALIZE_PASS_END(ArgPromotion, "argpromotion", INITIALIZE_PASS_END(ArgPromotion, "argpromotion",
"Promote 'by reference' arguments to scalars", false, false) "Promote 'by reference' arguments to scalars", false, false)
Pass *llvm::createArgumentPromotionPass(unsigned MaxElements) { Pass *llvm::createArgumentPromotionPass(unsigned MaxElements) {
return new ArgPromotion(MaxElements); return new ArgPromotion(GL_NUMPROMARGS);
} }
jdoerfertUnsubmitted
Done
ReplyInline Actions

Please do not simply ignore the argument MaxElements that is passed here by the user of this function. If you want to modify the default for the old pass manager, which is using this function, please update the call site where there is a 3.

jdoerfert: Please do not simply ignore the argument `MaxElements` that is passed here by the user of this…
jdoerfertUnsubmitted
Not Done
ReplyInline Actions

Where is the change in the pass manager?

jdoerfert: Where is the change in the pass manager?
bool ArgPromotion::runOnSCC(CallGraphSCC &SCC) { bool ArgPromotion::runOnSCC(CallGraphSCC &SCC) {
if (skipSCC(SCC)) if (skipSCC(SCC))
return false; return false;
// Get the callgraph information that we need to update to reflect our // Get the callgraph information that we need to update to reflect our
// changes. // changes.
CallGraph &CG = getAnalysis<CallGraphWrapperPass>().getCallGraph(); CallGraph &CG = getAnalysis<CallGraphWrapperPass>().getCallGraph();
▲ Show 20 Lines • Show All 51 Lines • Show Last 20 Lines

llvm/test/Transforms/ArgumentPromotion/fourmember-struct-promote-DEFAULT.ll

  • This file was added.
; RUN: opt < %s -basic-aa -mem2reg -argpromotion -mem2reg -S | FileCheck %s
jdoerfertUnsubmitted
Done
ReplyInline Actions

run mem2reg on the file *before* making it a test, not here.

jdoerfert: run mem2reg on the file *before* making it a test, not here.
target datalayout = "e-m:o-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
%struct.fourmem = type { i32, i32, i32, i32 }
; Function Attrs: noinline norecurse ssp uwtable
define i32 @main() #0 {
; CHECK-LABEL: define {{[^@]+}}@main()
; CHECK-NEXT: entry:
; CHECK-NEXT: [[F:%.*]] = alloca {{.*}}
; CHECK-NEXT: {{%.*}} = getelementptr {{.*}}
; CHECK-NEXT: store {{.*}}
; CHECK-NEXT: {{%.*}} = getelementptr {{.*}}
; CHECK-NEXT: store {{.*}}
; CHECK-NEXT: {{%.*}} = getelementptr {{.*}}
; CHECK-NEXT: store {{.*}}
; CHECK-NEXT: {{%.*}} = getelementptr {{.*}}
; CHECK-NEXT: store {{.*}}
; CHECK-NEXT: [[F]].idx{{.*}} = getelementptr %struct.fourmem, %struct.fourmem* [[F]], i64 0, i32 0
; CHECK-NEXT: [[F]].idx{{.*}}.val = load i32, i32* [[F]].idx{{.*}}, align 4
; CHECK-NEXT: [[F]].idx{{.*}} = getelementptr %struct.fourmem, %struct.fourmem* [[F]], i64 0, i32 1
; CHECK-NEXT: [[F]].idx{{.*}}.val = load i32, i32* [[F]].idx{{.*}}, align 4
; CHECK-NEXT: [[F]].idx{{.*}} = getelementptr %struct.fourmem, %struct.fourmem* [[F]], i64 0, i32 2
; CHECK-NEXT: [[F]].idx{{.*}}.val = load i32, i32* [[F]].idx{{.*}}, align 4
; CHECK-NEXT: [[F]].idx{{.*}} = getelementptr %struct.fourmem, %struct.fourmem* [[F]], i64 0, i32 3
; CHECK-NEXT: [[F]].idx{{.*}}.val = load i32, i32* [[F]].idx{{.*}}, align 4
; CHECK-NEXT: %{{.*}} = call i32 @{{.*}}fourmem(i32 [[F]].idx{{.*}}.val, i32 [[F]].idx{{.*}}.val, i32 [[F]].idx{{.*}}.val, i32 [[F]].idx{{.*}}.val)
; CHECK-NEXT: ret i32 0
;
entry:
%retval = alloca i32, align 4
%four = alloca %struct.fourmem, align 4
%T = alloca i32, align 4
store i32 0, i32* %retval, align 4
%a = getelementptr inbounds %struct.fourmem, %struct.fourmem* %four, i32 0, i32 0
store i32 1, i32* %a, align 4
%b = getelementptr inbounds %struct.fourmem, %struct.fourmem* %four, i32 0, i32 1
store i32 2, i32* %b, align 4
%c = getelementptr inbounds %struct.fourmem, %struct.fourmem* %four, i32 0, i32 2
store i32 3, i32* %c, align 4
%d = getelementptr inbounds %struct.fourmem, %struct.fourmem* %four, i32 0, i32 3
store i32 4, i32* %d, align 4
%call = call i32 @_ZL6calleeP7fourmem(%struct.fourmem* %four)
store i32 %call, i32* %T, align 4
ret i32 0
}
; Function Attrs: noinline nounwind ssp uwtable
define internal i32 @_ZL6calleeP7fourmem(%struct.fourmem* %t) #1 {
; CHECK-LABEL: define {{[^@]+}}@{{.*}}fourmem
; CHECK-SAME: (i32 %t.0.{{.*}}.val, i32 %t.0.{{.*}}.val, i32 %t.0.{{.*}}.val, i32 %t.0.{{.*}}.val)
; CHECK-NEXT: entry:
; CHECK-NEXT: %add{{.*}} = add nsw i32 {{.*}}, {{.*}}
; CHECK-NEXT: %add{{.*}} = add nsw i32 {{.*}}, {{.*}}
; CHECK-NEXT: %add{{.*}} = add nsw i32 {{.*}}, {{.*}}
; CHECK-NEXT: ret i32 %{{.*}}
;
entry:
%t.addr = alloca %struct.fourmem*, align 8
%S = alloca i32, align 4
store %struct.fourmem* %t, %struct.fourmem** %t.addr, align 8
%0 = load %struct.fourmem*, %struct.fourmem** %t.addr, align 8
%a = getelementptr inbounds %struct.fourmem, %struct.fourmem* %0, i32 0, i32 0
%1 = load i32, i32* %a, align 4
%2 = load %struct.fourmem*, %struct.fourmem** %t.addr, align 8
%b = getelementptr inbounds %struct.fourmem, %struct.fourmem* %2, i32 0, i32 1
%3 = load i32, i32* %b, align 4
%add = add nsw i32 %1, %3
%4 = load %struct.fourmem*, %struct.fourmem** %t.addr, align 8
%c = getelementptr inbounds %struct.fourmem, %struct.fourmem* %4, i32 0, i32 2
%5 = load i32, i32* %c, align 4
%add1 = add nsw i32 %add, %5
%6 = load %struct.fourmem*, %struct.fourmem** %t.addr, align 8
%d = getelementptr inbounds %struct.fourmem, %struct.fourmem* %6, i32 0, i32 3
%7 = load i32, i32* %d, align 4
%add2 = add nsw i32 %add1, %7
store i32 %add2, i32* %S, align 4
%8 = load i32, i32* %S, align 4
ret i32 %8
}
attributes #0 = { noinline norecurse ssp uwtable "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "frame-pointer"="all" "less-precise-fpmad"="false" "min-legal-vector-width"="0" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-cpu"="penryn" "target-features"="+cx16,+cx8,+fxsr,+mmx,+sahf,+sse,+sse2,+sse3,+sse4.1,+ssse3,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
attributes #1 = { noinline nounwind ssp uwtable "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "frame-pointer"="all" "less-precise-fpmad"="false" "min-legal-vector-width"="0" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-cpu"="penryn" "target-features"="+cx16,+cx8,+fxsr,+mmx,+sahf,+sse,+sse2,+sse3,+sse4.1,+ssse3,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
!llvm.module.flags = !{!0, !1}
!llvm.ident = !{!2}
!0 = !{i32 1, !"wchar_size", i32 4}
!1 = !{i32 7, !"PIC Level", i32 2}
!2 = !{!"clang version 11.0.0 (https://github.com/teamiceberg/llvm-project.git 1fb9041df0182c3e582bfcb5875e6af743eab0a1)"}
jdoerfertUnsubmitted
Done
ReplyInline Actions

No need for the metadata and attributes at the end of this file, please remove.

jdoerfert: No need for the metadata and attributes at the end of this file, please remove.
No newline at end of file

llvm/test/Transforms/ArgumentPromotion/fourmember-struct-promote-INTMAX.ll

  • This file was added.
; RUN: opt < %s -basic-aa -mem2reg -argpromotion -mem2reg -numargspromoted=2147483647 -S | FileCheck %s
jdoerfertUnsubmitted
Done
ReplyInline Actions

Please merge all three test files into one with 3 RUN lines and different check labels.

jdoerfert: Please merge all three test files into one with 3 RUN lines and different check labels.
target datalayout = "e-m:o-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
%struct.fourmem = type { i32, i32, i32, i32 }
; Function Attrs: noinline norecurse ssp uwtable
define i32 @main() #0 {
; CHECK-LABEL: define {{[^@]+}}@main()
; CHECK-NEXT: entry:
; CHECK-NEXT: [[F:%.*]] = alloca {{.*}}
; CHECK-NEXT: {{%.*}} = getelementptr {{.*}}
; CHECK-NEXT: store {{.*}}
; CHECK-NEXT: {{%.*}} = getelementptr {{.*}}
; CHECK-NEXT: store {{.*}}
; CHECK-NEXT: {{%.*}} = getelementptr {{.*}}
; CHECK-NEXT: store {{.*}}
; CHECK-NEXT: {{%.*}} = getelementptr {{.*}}
; CHECK-NEXT: store {{.*}}
; CHECK-NEXT: [[F]].idx{{.*}} = getelementptr %struct.fourmem, %struct.fourmem* [[F]], i64 0, i32 0
; CHECK-NEXT: [[F]].idx{{.*}}.val = load i32, i32* [[F]].idx{{.*}}, align 4
; CHECK-NEXT: [[F]].idx{{.*}} = getelementptr %struct.fourmem, %struct.fourmem* [[F]], i64 0, i32 1
; CHECK-NEXT: [[F]].idx{{.*}}.val = load i32, i32* [[F]].idx{{.*}}, align 4
; CHECK-NEXT: [[F]].idx{{.*}} = getelementptr %struct.fourmem, %struct.fourmem* [[F]], i64 0, i32 2
; CHECK-NEXT: [[F]].idx{{.*}}.val = load i32, i32* [[F]].idx{{.*}}, align 4
; CHECK-NEXT: [[F]].idx{{.*}} = getelementptr %struct.fourmem, %struct.fourmem* [[F]], i64 0, i32 3
; CHECK-NEXT: [[F]].idx{{.*}}.val = load i32, i32* [[F]].idx{{.*}}, align 4
; CHECK-NEXT: %{{.*}} = call i32 @{{.*}}fourmem(i32 [[F]].idx{{.*}}.val, i32 [[F]].idx{{.*}}.val, i32 [[F]].idx{{.*}}.val, i32 [[F]].idx{{.*}}.val)
; CHECK-NEXT: ret i32 0
;
entry:
%retval = alloca i32, align 4
%four = alloca %struct.fourmem, align 4
%T = alloca i32, align 4
store i32 0, i32* %retval, align 4
%a = getelementptr inbounds %struct.fourmem, %struct.fourmem* %four, i32 0, i32 0
store i32 1, i32* %a, align 4
%b = getelementptr inbounds %struct.fourmem, %struct.fourmem* %four, i32 0, i32 1
store i32 2, i32* %b, align 4
%c = getelementptr inbounds %struct.fourmem, %struct.fourmem* %four, i32 0, i32 2
store i32 3, i32* %c, align 4
%d = getelementptr inbounds %struct.fourmem, %struct.fourmem* %four, i32 0, i32 3
store i32 4, i32* %d, align 4
%call = call i32 @_ZL6calleeP7fourmem(%struct.fourmem* %four)
store i32 %call, i32* %T, align 4
ret i32 0
}
; Function Attrs: noinline nounwind ssp uwtable
define internal i32 @_ZL6calleeP7fourmem(%struct.fourmem* %t) #1 {
; CHECK-LABEL: define {{[^@]+}}@{{.*}}fourmem
; CHECK-SAME: (i32 %t.0.{{.*}}.val, i32 %t.0.{{.*}}.val, i32 %t.0.{{.*}}.val, i32 %t.0.{{.*}}.val)
; CHECK-NEXT: entry:
; CHECK-NEXT: %add{{.*}} = add nsw i32 {{.*}}, {{.*}}
; CHECK-NEXT: %add{{.*}} = add nsw i32 {{.*}}, {{.*}}
; CHECK-NEXT: %add{{.*}} = add nsw i32 {{.*}}, {{.*}}
; CHECK-NEXT: ret i32 %{{.*}}
;
entry:
%t.addr = alloca %struct.fourmem*, align 8
%S = alloca i32, align 4
store %struct.fourmem* %t, %struct.fourmem** %t.addr, align 8
%0 = load %struct.fourmem*, %struct.fourmem** %t.addr, align 8
%a = getelementptr inbounds %struct.fourmem, %struct.fourmem* %0, i32 0, i32 0
%1 = load i32, i32* %a, align 4
%2 = load %struct.fourmem*, %struct.fourmem** %t.addr, align 8
%b = getelementptr inbounds %struct.fourmem, %struct.fourmem* %2, i32 0, i32 1
%3 = load i32, i32* %b, align 4
%add = add nsw i32 %1, %3
%4 = load %struct.fourmem*, %struct.fourmem** %t.addr, align 8
%c = getelementptr inbounds %struct.fourmem, %struct.fourmem* %4, i32 0, i32 2
%5 = load i32, i32* %c, align 4
%add1 = add nsw i32 %add, %5
%6 = load %struct.fourmem*, %struct.fourmem** %t.addr, align 8
%d = getelementptr inbounds %struct.fourmem, %struct.fourmem* %6, i32 0, i32 3
%7 = load i32, i32* %d, align 4
%add2 = add nsw i32 %add1, %7
store i32 %add2, i32* %S, align 4
%8 = load i32, i32* %S, align 4
ret i32 %8
}
attributes #0 = { noinline norecurse ssp uwtable "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "frame-pointer"="all" "less-precise-fpmad"="false" "min-legal-vector-width"="0" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-cpu"="penryn" "target-features"="+cx16,+cx8,+fxsr,+mmx,+sahf,+sse,+sse2,+sse3,+sse4.1,+ssse3,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
attributes #1 = { noinline nounwind ssp uwtable "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "frame-pointer"="all" "less-precise-fpmad"="false" "min-legal-vector-width"="0" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-cpu"="penryn" "target-features"="+cx16,+cx8,+fxsr,+mmx,+sahf,+sse,+sse2,+sse3,+sse4.1,+ssse3,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
!llvm.module.flags = !{!0, !1}
!llvm.ident = !{!2}
!0 = !{i32 1, !"wchar_size", i32 4}
!1 = !{i32 7, !"PIC Level", i32 2}
!2 = !{!"clang version 11.0.0 (https://github.com/teamiceberg/llvm-project.git 1fb9041df0182c3e582bfcb5875e6af743eab0a1)"}

llvm/test/Transforms/ArgumentPromotion/fourmember-struct-promote-ZERO.ll

  • This file was added.
; RUN: opt < %s -basic-aa -mem2reg -argpromotion -mem2reg -numargspromoted=0 -S | FileCheck %s
target datalayout = "e-m:o-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
%struct.fourmem = type { i32, i32, i32, i32 }
; Function Attrs: noinline norecurse ssp uwtable
define i32 @main() #0 {
; CHECK-LABEL: define {{[^@]+}}@main()
; CHECK-NEXT: entry:
; CHECK-NEXT: [[F:%.*]] = alloca {{.*}}
; CHECK-NEXT: {{%.*}} = getelementptr {{.*}}
; CHECK-NEXT: store {{.*}}
; CHECK-NEXT: {{%.*}} = getelementptr {{.*}}
; CHECK-NEXT: store {{.*}}
; CHECK-NEXT: {{%.*}} = getelementptr {{.*}}
; CHECK-NEXT: store {{.*}}
; CHECK-NEXT: {{%.*}} = getelementptr {{.*}}
; CHECK-NEXT: store {{.*}}
; CHECK-NEXT: [[F]].idx{{.*}} = getelementptr %struct.fourmem, %struct.fourmem* [[F]], i64 0, i32 0
; CHECK-NEXT: [[F]].idx{{.*}}.val = load i32, i32* [[F]].idx{{.*}}, align 4
; CHECK-NEXT: [[F]].idx{{.*}} = getelementptr %struct.fourmem, %struct.fourmem* [[F]], i64 0, i32 1
; CHECK-NEXT: [[F]].idx{{.*}}.val = load i32, i32* [[F]].idx{{.*}}, align 4
; CHECK-NEXT: [[F]].idx{{.*}} = getelementptr %struct.fourmem, %struct.fourmem* [[F]], i64 0, i32 2
; CHECK-NEXT: [[F]].idx{{.*}}.val = load i32, i32* [[F]].idx{{.*}}, align 4
; CHECK-NEXT: [[F]].idx{{.*}} = getelementptr %struct.fourmem, %struct.fourmem* [[F]], i64 0, i32 3
; CHECK-NEXT: [[F]].idx{{.*}}.val = load i32, i32* [[F]].idx{{.*}}, align 4
; CHECK-NEXT: %{{.*}} = call i32 @{{.*}}fourmem(i32 [[F]].idx{{.*}}.val, i32 [[F]].idx{{.*}}.val, i32 [[F]].idx{{.*}}.val, i32 [[F]].idx{{.*}}.val)
; CHECK-NEXT: ret i32 0
;
entry:
%retval = alloca i32, align 4
%four = alloca %struct.fourmem, align 4
%T = alloca i32, align 4
store i32 0, i32* %retval, align 4
%a = getelementptr inbounds %struct.fourmem, %struct.fourmem* %four, i32 0, i32 0
store i32 1, i32* %a, align 4
%b = getelementptr inbounds %struct.fourmem, %struct.fourmem* %four, i32 0, i32 1
store i32 2, i32* %b, align 4
%c = getelementptr inbounds %struct.fourmem, %struct.fourmem* %four, i32 0, i32 2
store i32 3, i32* %c, align 4
%d = getelementptr inbounds %struct.fourmem, %struct.fourmem* %four, i32 0, i32 3
store i32 4, i32* %d, align 4
%call = call i32 @_ZL6calleeP7fourmem(%struct.fourmem* %four)
store i32 %call, i32* %T, align 4
ret i32 0
}
; Function Attrs: noinline nounwind ssp uwtable
define internal i32 @_ZL6calleeP7fourmem(%struct.fourmem* %t) #1 {
; CHECK-LABEL: define {{[^@]+}}@{{.*}}fourmem
; CHECK-SAME: (i32 %t.0.{{.*}}.val, i32 %t.0.{{.*}}.val, i32 %t.0.{{.*}}.val, i32 %t.0.{{.*}}.val)
; CHECK-NEXT: entry:
; CHECK-NEXT: %add{{.*}} = add nsw i32 {{.*}}, {{.*}}
; CHECK-NEXT: %add{{.*}} = add nsw i32 {{.*}}, {{.*}}
; CHECK-NEXT: %add{{.*}} = add nsw i32 {{.*}}, {{.*}}
; CHECK-NEXT: ret i32 %{{.*}}
;
entry:
%t.addr = alloca %struct.fourmem*, align 8
%S = alloca i32, align 4
store %struct.fourmem* %t, %struct.fourmem** %t.addr, align 8
%0 = load %struct.fourmem*, %struct.fourmem** %t.addr, align 8
%a = getelementptr inbounds %struct.fourmem, %struct.fourmem* %0, i32 0, i32 0
%1 = load i32, i32* %a, align 4
%2 = load %struct.fourmem*, %struct.fourmem** %t.addr, align 8
%b = getelementptr inbounds %struct.fourmem, %struct.fourmem* %2, i32 0, i32 1
%3 = load i32, i32* %b, align 4
%add = add nsw i32 %1, %3
%4 = load %struct.fourmem*, %struct.fourmem** %t.addr, align 8
%c = getelementptr inbounds %struct.fourmem, %struct.fourmem* %4, i32 0, i32 2
%5 = load i32, i32* %c, align 4
%add1 = add nsw i32 %add, %5
%6 = load %struct.fourmem*, %struct.fourmem** %t.addr, align 8
%d = getelementptr inbounds %struct.fourmem, %struct.fourmem* %6, i32 0, i32 3
%7 = load i32, i32* %d, align 4
%add2 = add nsw i32 %add1, %7
store i32 %add2, i32* %S, align 4
%8 = load i32, i32* %S, align 4
ret i32 %8
}
attributes #0 = { noinline norecurse ssp uwtable "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "frame-pointer"="all" "less-precise-fpmad"="false" "min-legal-vector-width"="0" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-cpu"="penryn" "target-features"="+cx16,+cx8,+fxsr,+mmx,+sahf,+sse,+sse2,+sse3,+sse4.1,+ssse3,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
attributes #1 = { noinline nounwind ssp uwtable "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "frame-pointer"="all" "less-precise-fpmad"="false" "min-legal-vector-width"="0" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-cpu"="penryn" "target-features"="+cx16,+cx8,+fxsr,+mmx,+sahf,+sse,+sse2,+sse3,+sse4.1,+ssse3,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
!llvm.module.flags = !{!0, !1}
!llvm.ident = !{!2}
!0 = !{i32 1, !"wchar_size", i32 4}
!1 = !{i32 7, !"PIC Level", i32 2}
!2 = !{!"clang version 11.0.0 (https://github.com/teamiceberg/llvm-project.git 1fb9041df0182c3e582bfcb5875e6af743eab0a1)"}