Page MenuHomePhabricator

[Matrix] Change the definitions of the load/store intrinsics
ClosedPublic

Authored by SjoerdMeijer on Jul 14 2020, 9:26 AM.

Details

Summary

This changes the definitions of the matrix load/store intrinsics to load/store from/to a pointer, and not to a vector, as discussed in D83477. I will commit this and D83477 as 1 commit, put am putting this new bit up for review separately because that makes this part easier to review.

Diff Detail

Event Timeline

SjoerdMeijer created this revision.Jul 14 2020, 9:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 14 2020, 9:26 AM

don't need new block scopes in the Verifier anymore.

fhahn accepted this revision.Jul 14 2020, 9:49 AM

LGTM, thank you very much! This has been discussed already in D83477. Passing in a pointer to a vector is confusing, as it seems to suggest we only access elements of the vector pointer, but we may access other elements, if the stride > rows.

This revision is now accepted and ready to land.Jul 14 2020, 9:49 AM

Thanks for reviewing!

This revision was automatically updated to reflect the committed changes.