This is an archive of the discontinued LLVM Phabricator instance.

Differential D83780

MIPS: change FeatureMadd4 to FeatureNoMadd4
ClosedPublic

Authored by wzssyqa on Jul 14 2020, 8:25 AM.

Details

Reviewers
atanasyan
Commits
rG3a6c2a61c642: [mips] Rename FeatureMadd4 to FeatureNoMadd4. NFC
Summary

FeatureMadd4 here is used to disable madd4, and the option is

(+-)nomadd4

This word is so confused here.
Changing to FeatureNoMadd4 makes it much more clear.

Diff Detail

Event Timeline

wzssyqa created this revision.Jul 14 2020, 8:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 14 2020, 8:25 AM
Herald added subscribers: llvm-commits, jrtc27, hiraditya and 2 others. · View Herald Transcript
Harbormaster failed remote builds in B64161: Diff 277840!Jul 14 2020, 8:59 AM
wzssyqa updated this revision to Diff 277863.Jul 14 2020, 9:05 AM
atanasyan accepted this revision.Jul 14 2020, 9:11 AM

LGTM

Do you have commit access?

This revision is now accepted and ready to land.Jul 14 2020, 9:11 AM
wzssyqa added a comment.Jul 14 2020, 9:14 AM
In D83780#2150683, @atanasyan wrote:

LGTM

Do you have commit access?

No. I don't have.

Closed by commit rG3a6c2a61c642: [mips] Rename FeatureMadd4 to FeatureNoMadd4. NFC (authored by wzssyqa, committed by atanasyan). · Explain WhyJul 15 2020, 4:40 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
lib/
Target/
Mips/
2 lines
2 lines

Diff 277863

llvm/lib/Target/Mips/Mips.td

Show First 20 Lines • Show All 185 Lines • ▼ Show 20 Linesdef FeatureCnMipsP : SubtargetFeature<"cnmipsp", "HasCnMipsP",
"true", "Octeon+ cnMIPS Support", "true", "Octeon+ cnMIPS Support",
[FeatureCnMips]>; [FeatureCnMips]>;
def FeatureUseTCCInDIV : SubtargetFeature< def FeatureUseTCCInDIV : SubtargetFeature<
"use-tcc-in-div", "use-tcc-in-div",
"UseTCCInDIV", "false", "UseTCCInDIV", "false",
"Force the assembler to use trapping">; "Force the assembler to use trapping">;
def FeatureMadd4 def FeatureNoMadd4
: SubtargetFeature<"nomadd4", "DisableMadd4", "true", : SubtargetFeature<"nomadd4", "DisableMadd4", "true",
"Disable 4-operand madd.fmt and related instructions">; "Disable 4-operand madd.fmt and related instructions">;
def FeatureMT : SubtargetFeature<"mt", "HasMT", "true", "Mips MT ASE">; def FeatureMT : SubtargetFeature<"mt", "HasMT", "true", "Mips MT ASE">;
def FeatureLongCalls : SubtargetFeature<"long-calls", "UseLongCalls", "true", def FeatureLongCalls : SubtargetFeature<"long-calls", "UseLongCalls", "true",
"Disable use of the jal instruction">; "Disable use of the jal instruction">;
▲ Show 20 Lines • Show All 79 Lines • Show Last 20 Lines

llvm/lib/Target/Mips/MipsInstrInfo.td

Show First 20 Lines • Show All 236 Lines • ▼ Show 20 Lines
def IsBE : Predicate<"!Subtarget->isLittle()">; def IsBE : Predicate<"!Subtarget->isLittle()">;
def IsNotNaCl : Predicate<"!Subtarget->isTargetNaCl()">; def IsNotNaCl : Predicate<"!Subtarget->isTargetNaCl()">;
def UseTCCInDIV : AssemblerPredicate<(all_of FeatureUseTCCInDIV)>; def UseTCCInDIV : AssemblerPredicate<(all_of FeatureUseTCCInDIV)>;
def HasEVA : Predicate<"Subtarget->hasEVA()">, def HasEVA : Predicate<"Subtarget->hasEVA()">,
AssemblerPredicate<(all_of FeatureEVA)>; AssemblerPredicate<(all_of FeatureEVA)>;
def HasMSA : Predicate<"Subtarget->hasMSA()">, def HasMSA : Predicate<"Subtarget->hasMSA()">,
AssemblerPredicate<(all_of FeatureMSA)>; AssemblerPredicate<(all_of FeatureMSA)>;
def HasMadd4 : Predicate<"!Subtarget->disableMadd4()">, def HasMadd4 : Predicate<"!Subtarget->disableMadd4()">,
AssemblerPredicate<(all_of (not FeatureMadd4))>; AssemblerPredicate<(all_of (not FeatureNoMadd4))>;
def HasMT : Predicate<"Subtarget->hasMT()">, def HasMT : Predicate<"Subtarget->hasMT()">,
AssemblerPredicate<(all_of FeatureMT)>; AssemblerPredicate<(all_of FeatureMT)>;
def UseIndirectJumpsHazard : Predicate<"Subtarget->useIndirectJumpsHazard()">, def UseIndirectJumpsHazard : Predicate<"Subtarget->useIndirectJumpsHazard()">,
AssemblerPredicate<(all_of FeatureUseIndirectJumpsHazard)>; AssemblerPredicate<(all_of FeatureUseIndirectJumpsHazard)>;
def NoIndirectJumpGuards : Predicate<"!Subtarget->useIndirectJumpsHazard()">, def NoIndirectJumpGuards : Predicate<"!Subtarget->useIndirectJumpsHazard()">,
AssemblerPredicate<(all_of (not FeatureUseIndirectJumpsHazard))>; AssemblerPredicate<(all_of (not FeatureUseIndirectJumpsHazard))>;
def HasCRC : Predicate<"Subtarget->hasCRC()">, def HasCRC : Predicate<"Subtarget->hasCRC()">,
AssemblerPredicate<(all_of FeatureCRC)>; AssemblerPredicate<(all_of FeatureCRC)>;
▲ Show 20 Lines • Show All 3,155 Lines • Show Last 20 Lines