Page MenuHomePhabricator

[WebAssembly] Prefer v128.const for constant splats
ClosedPublic

Authored by tlively on Jul 10 2020, 12:12 PM.

Details

Summary

In BUILD_VECTOR lowering, we used to generally prefer using splats
over v128.const instructions because v128.const has a very large
encoding. However, in d5b7a4e2e8 we switched to preferring consts
because they are expected to be more efficient in engines. This patch
updates the ISel patterns to match this current preference.

Diff Detail

Event Timeline

tlively created this revision.Jul 10 2020, 12:12 PM
aheejin accepted this revision.Jul 10 2020, 4:45 PM
This revision is now accepted and ready to land.Jul 10 2020, 4:45 PM
This revision was automatically updated to reflect the committed changes.