This is an archive of the discontinued LLVM Phabricator instance.

Differential D83385

[mlir] Add ViewLikeOpInterface to std.memref_cast.
ClosedPublic

Authored by pifon2a on Jul 8 2020, 4:45 AM.

Details

Reviewers
herhut
Commits
rG1ea289681acf: [mlir] Add ViewLikeOpInterface to std.memref_cast.
Summary

It's needed for correct work of BufferPlacement.

Diff Detail

Event Timeline

pifon2a created this revision.Jul 8 2020, 4:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 8 2020, 4:45 AM
Herald added subscribers: msifontes, jurahul, Kayjukh and 14 others. · View Herald Transcript
Harbormaster completed remote builds in B63390: Diff 276375.Jul 8 2020, 5:02 AM
herhut accepted this revision.Jul 8 2020, 5:11 AM

Can you update the commit message so that it has a summary (first sentence) and description?

This revision is now accepted and ready to land.Jul 8 2020, 5:11 AM
Closed by commit rG1ea289681acf: [mlir] Add ViewLikeOpInterface to std.memref_cast. (authored by pifon2a). · Explain WhyJul 8 2020, 5:33 AM
This revision was automatically updated to reflect the committed changes.
pifon2a retitled this revision from [mlir] Add ViewLikeOpInterface to std.memref_cast. It's needed for correct work of BufferPlacement. to [mlir] Add ViewLikeOpInterface to std.memref_cast..Jul 8 2020, 5:33 AM
pifon2a edited the summary of this revision. (Show Details)

Revision Contents

PathSize
mlir/
include/
mlir/
Dialect/
StandardOps/
IR/
4 lines
lib/
Dialect/
StandardOps/
IR/
2 lines

Diff 276390

mlir/include/mlir/Dialect/StandardOps/IR/Ops.td

Show First 20 Lines • Show All 1,766 Lines • ▼ Show 20 Lines
def Log2Op : FloatUnaryOp<"log2"> { def Log2Op : FloatUnaryOp<"log2"> {
let summary = "base-2 logarithm of the specified value"; let summary = "base-2 logarithm of the specified value";
} }
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// MemRefCastOp // MemRefCastOp
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
def MemRefCastOp : CastOp<"memref_cast"> { def MemRefCastOp : CastOp<"memref_cast", [
DeclareOpInterfaceMethods<ViewLikeOpInterface>
]> {
let summary = "memref cast operation"; let summary = "memref cast operation";
let description = [{ let description = [{
Syntax: Syntax:
``` ```
operation ::= ssa-id `=` `std.memref_cast` ssa-use `:` type `to` type operation ::= ssa-id `=` `std.memref_cast` ssa-use `:` type `to` type
``` ```
▲ Show 20 Lines • Show All 1,466 Lines • Show Last 20 Lines

mlir/lib/Dialect/StandardOps/IR/Ops.cpp

Show First 20 Lines • Show All 1,816 Lines • ▼ Show 20 Lines if (succeeded(foldMemRefCast(*this)))
return getResult(); return getResult();
return OpFoldResult(); return OpFoldResult();
} }
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// MemRefCastOp // MemRefCastOp
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
Value MemRefCastOp::getViewSource() { return source(); }
bool MemRefCastOp::areCastCompatible(Type a, Type b) { bool MemRefCastOp::areCastCompatible(Type a, Type b) {
auto aT = a.dyn_cast<MemRefType>(); auto aT = a.dyn_cast<MemRefType>();
auto bT = b.dyn_cast<MemRefType>(); auto bT = b.dyn_cast<MemRefType>();
auto uaT = a.dyn_cast<UnrankedMemRefType>(); auto uaT = a.dyn_cast<UnrankedMemRefType>();
auto ubT = b.dyn_cast<UnrankedMemRefType>(); auto ubT = b.dyn_cast<UnrankedMemRefType>();
if (aT && bT) { if (aT && bT) {
▲ Show 20 Lines • Show All 1,412 Lines • Show Last 20 Lines