This is an archive of the discontinued LLVM Phabricator instance.

[Tsan] Do not sanitize memcpy() during thread initialization on FreeBSD
ClosedPublic

Authored by kutuzov.viktor.84 on Mar 13 2015, 11:12 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

kutuzov.viktor.84 retitled this revision from to [Tsan] Do not sanitize memcpy() during thread initialization on FreeBSD.
kutuzov.viktor.84 updated this object.
kutuzov.viktor.84 edited the test plan for this revision. (Show Details)
kutuzov.viktor.84 added a subscriber: Unknown Object (MLST).
dvyukov added inline comments.Mar 13 2015, 11:22 AM
lib/tsan/rtl/tsan_interceptors.cc
673 ↗(On Diff #21940)

please add is_inited flag to ThreadState, similar to is_dead
and set it in ThreadContext::OnStarted
shadow_stack_pos check looks confusing

dvyukov accepted this revision.Mar 16 2015, 7:38 AM
dvyukov edited edge metadata.

LGTM

This revision is now accepted and ready to land.Mar 16 2015, 7:38 AM
This revision was automatically updated to reflect the committed changes.