This is an archive of the discontinued LLVM Phabricator instance.

[ARM][MVE] Refactor option -disable-mve-tail-predication
ClosedPublic

Authored by SjoerdMeijer on Jul 3 2020, 7:45 AM.

Details

Summary

This refactors option -disable-mve-tail-predication to take different arguments so that we have 1 option to control tail-predication rather than several different ones.

This is also a prep step for D82953, in which we want to reject reductions unless that is requested with this option.

Diff Detail

Event Timeline

SjoerdMeijer created this revision.Jul 3 2020, 7:45 AM
dmgreen accepted this revision.Jul 13 2020, 2:49 AM

Sounds good to me. It may get a bit unwieldy to have one option with many preferences, but looks OK with these ones.

This revision is now accepted and ready to land.Jul 13 2020, 2:49 AM

Thanks, and yes, we can/should revise this later. For now this should be an improvement, because I needed 3 different options for tail-predication, which was a becoming unwieldy :-) It should only become simpler from now on as reductions are a special case at the moment, but that should disappear at some point.

This revision was automatically updated to reflect the committed changes.