This is an archive of the discontinued LLVM Phabricator instance.

Differential D83067

[BasicAA] Remove -basicaa alias
ClosedPublic

Authored by aeubanks on Jul 2 2020, 11:38 AM.

Details

Reviewers
ychen
arsenm
reames
Commits
rG83158cf95dd7: [BasicAA] Remove -basicaa alias
Summary

Follow up of https://reviews.llvm.org/D82607.

Diff Detail

Unit TestsFailed

TimeTest
60 mslinux > Polly.Isl/CodeGen/MemAccess::Unknown Unit Message ("")
80 mslinux > Polly.ScopInfo::Unknown Unit Message ("")
10,420 mslinux > libomp.env::Unknown Unit Message ("")
1,630 mslinux > libomp.worksharing/for::Unknown Unit Message ("")

Event Timeline

aeubanks created this revision.Jul 2 2020, 11:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 2 2020, 11:38 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
aeubanks added reviewers: ychen, arsenm, reames.Jul 2 2020, 11:39 AM
Herald added a subscriber: wdng. · View Herald TranscriptJul 2 2020, 11:39 AM
Harbormaster failed remote builds in B62727: Diff 275179!Jul 2 2020, 12:25 PM
ychen accepted this revision.Jul 6 2020, 11:41 AM

LGTM

This revision is now accepted and ready to land.Jul 6 2020, 11:41 AM
Closed by commit rG83158cf95dd7: [BasicAA] Remove -basicaa alias (authored by aeubanks). · Explain WhyJul 7 2020, 10:44 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
include/
llvm/
IR/
5 lines
test/
Analysis/
BasicAA/
1 line

Diff 275179

llvm/include/llvm/IR/LegacyPassNameParser.h

Show First 20 Lines • Show All 67 Lines • ▼ Show 20 Linespublic:
void passRegistered(const PassInfo *P) override { void passRegistered(const PassInfo *P) override {
if (ignorablePass(P)) return; if (ignorablePass(P)) return;
if (findOption(P->getPassArgument().data()) != getNumOptions()) { if (findOption(P->getPassArgument().data()) != getNumOptions()) {
errs() << "Two passes with the same argument (-" errs() << "Two passes with the same argument (-"
<< P->getPassArgument() << ") attempted to be registered!\n"; << P->getPassArgument() << ") attempted to be registered!\n";
llvm_unreachable(nullptr); llvm_unreachable(nullptr);
} }
addLiteralOption(P->getPassArgument().data(), P, P->getPassName().data()); addLiteralOption(P->getPassArgument().data(), P, P->getPassName().data());
// Temporary alias for basicaa -> basic-aa
// TODO: remove once everything is migrated to basic-aa
if (P->getPassArgument() == "basic-aa")
addLiteralOption("basicaa", P, "deprecated alias for basic-aa");
} }
void passEnumerate(const PassInfo *P) override { passRegistered(P); } void passEnumerate(const PassInfo *P) override { passRegistered(P); }
// printOptionInfo - Print out information about this option. Override the // printOptionInfo - Print out information about this option. Override the
// default implementation to sort the table before we print... // default implementation to sort the table before we print...
void printOptionInfo(const cl::Option &O, size_t GlobalWidth) const override { void printOptionInfo(const cl::Option &O, size_t GlobalWidth) const override {
PassNameParser *PNP = const_cast<PassNameParser*>(this); PassNameParser *PNP = const_cast<PassNameParser*>(this);
array_pod_sort(PNP->Values.begin(), PNP->Values.end(), ValCompare); array_pod_sort(PNP->Values.begin(), PNP->Values.end(), ValCompare);
Show All 14 Lines

llvm/test/Analysis/BasicAA/empty.ll

; RUN: opt < %s -basicaa -aa-eval -print-all-alias-modref-info -disable-output 2>&1 | FileCheck %s
; RUN: opt < %s -basic-aa -aa-eval -print-all-alias-modref-info -disable-output 2>&1 | FileCheck %s ; RUN: opt < %s -basic-aa -aa-eval -print-all-alias-modref-info -disable-output 2>&1 | FileCheck %s
target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64" target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64"
; CHECK: Function: foo: ; CHECK: Function: foo:
; CHECK-NEXT: NoAlias: {}* %p, {}* %q ; CHECK-NEXT: NoAlias: {}* %p, {}* %q
define void @foo({}* %p, {}* %q) { define void @foo({}* %p, {}* %q) {
store {} {}, {}* %p store {} {}, {}* %p
store {} {}, {}* %q store {} {}, {}* %q
ret void ret void
} }