This is an archive of the discontinued LLVM Phabricator instance.

[NewPM] Add -basic-aa to pr33196.ll
ClosedPublic

Authored by aeubanks on Jun 30 2020, 2:47 PM.

Download Raw Diff

Details

Reviewers

fhahn
asbirlea

Commits

rG0059f6ffe842: [NewPM] Add -basic-aa to pr33196.ll

Summary

The legacy pass manager implicitly adds BasicAA, but the new PM does
not. This causes pr33196.ll to fail under NPM.

There are almost certainly lots of other failures like this, wanted to
get some input on if adding -basic-aa to tests makes sense at scale.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed

	Time	Test
	11,740 ms	linux > libomp.env::Unknown Unit Message ("")
	1,780 ms	linux > libomp.worksharing/for::Unknown Unit Message ("")

Event Timeline

aeubanks created this revision.Jun 30 2020, 2:47 PM

Herald added a project: Restricted Project. · View Herald TranscriptJun 30 2020, 2:47 PM

Herald added a subscriber: llvm-commits. · View Herald Transcript

Harbormaster failed remote builds in B62409: Diff 274621!Jun 30 2020, 4:18 PM

LGTM, thanks

This revision is now accepted and ready to land.Jul 1 2020, 12:04 AM

This makes sense to me (at least for the NewGVN tests), but it might be good to wait a bit in case there are additional thoughts on the bigger picture.

Closed by commit rG0059f6ffe842: [NewPM] Add -basic-aa to pr33196.ll (authored by aeubanks). · Explain WhyJul 2 2020, 11:53 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

llvm/

test/

Transforms/

NewGVN/

pr33196.ll

2 lines

Diff 274621

llvm/test/Transforms/NewGVN/pr33196.ll

	; RUN: opt -S -newgvn %s \| FileCheck %s			; RUN: opt -S -basic-aa -newgvn %s \| FileCheck %s

	; CHECK: define i32 @main() {			; CHECK: define i32 @main() {
	; CHECK-NEXT: entry:			; CHECK-NEXT: entry:
	; CHECK-NEXT: %tmp = load i32, i32* @d, align 4			; CHECK-NEXT: %tmp = load i32, i32* @d, align 4
	; CHECK-NEXT: %tmp1 = load i32, i32* @c, align 4			; CHECK-NEXT: %tmp1 = load i32, i32* @c, align 4
	; CHECK-NEXT: %tobool = icmp eq i32 %tmp1, -1			; CHECK-NEXT: %tobool = icmp eq i32 %tmp1, -1
	; CHECK-NEXT: br i1 %tobool, label %if.end, label %if.then			; CHECK-NEXT: br i1 %tobool, label %if.end, label %if.then
	; CHECK: if.then:			; CHECK: if.then:
	▲ Show 20 Lines • Show All 63 Lines • Show Last 20 Lines