This is an archive of the discontinued LLVM Phabricator instance.

[MLIR][Shape] Fix lowering of `shape.get_extent`
ClosedPublic

Authored by frgossen on Jun 29 2020, 11:48 AM.

Details

Summary

The declarative conversion patterns caused crashes in the asan configuration.
The non-declarative implementation circumvents this.

Diff Detail

Event Timeline

frgossen created this revision.Jun 29 2020, 11:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 29 2020, 11:48 AM
pifon2a accepted this revision.Jun 30 2020, 12:47 AM

Thank you!

mlir/lib/Conversion/ShapeToStandard/ShapeToStandard.cpp
104

nit:

if (auto shapeOfOp = op.shape().getDefiningOp<ShapeOfOp>()) {
This revision is now accepted and ready to land.Jun 30 2020, 12:47 AM
frgossen updated this revision to Diff 274357.Jun 30 2020, 1:12 AM
frgossen marked an inline comment as done.

Address nit

This revision was automatically updated to reflect the committed changes.