This is an archive of the discontinued LLVM Phabricator instance.

[NewPM][BasicAA] basicaa -> basic-aa in Transforms/{New,}GVN
ClosedPublic

Authored by aeubanks on Jun 26 2020, 3:13 PM.

Diff Detail

Event Timeline

aeubanks created this revision.Jun 26 2020, 3:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 26 2020, 3:13 PM
asbirlea accepted this revision.Jun 26 2020, 3:50 PM

Thanks you!

This revision is now accepted and ready to land.Jun 26 2020, 3:50 PM
This revision was automatically updated to reflect the committed changes.

Hi, your git commit contains extra Phabricator tags. You can drop Reviewers: Subscribers: Tags: and the text Summary: from the git commit with the following script:

arcfilter () {
        arc amend
        git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:$/ {sub(/^Summary: /,"");print}' | git commit --amend --date=now -F -
}

Reviewed By: is considered important by some people. Please keep the tag. (I have updated my script to use --date=now (setting author date to committer date))

https://reviews.llvm.org/D80978 contains a git pre-push hook to automate this.