This is an archive of the discontinued LLVM Phabricator instance.

[FileCheck][NFC] Clean up RUN style in verbose.txt test
ClosedPublic

Authored by jdenny on Jun 26 2020, 7:25 AM.

Diff Detail

Event Timeline

jdenny created this revision.Jun 26 2020, 7:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 26 2020, 7:25 AM
thopre accepted this revision.Jun 26 2020, 7:45 AM

LGTM

This revision is now accepted and ready to land.Jun 26 2020, 7:45 AM
jhenderson accepted this revision.Jun 29 2020, 12:03 AM

LGTM, with optional suggestion.

llvm/test/FileCheck/verbose.txt
2–3

Can I make one minor suggestion whilst you're changing these lines: Change the single-dash arguments for double-dash (or vice versa, but I prefer the first). The reason is that there's an inconsistency in the number of dashes for different options, and it would be nice if it were consistent. It's not a big deal at all of course!

jdenny marked an inline comment as done.Jun 29 2020, 6:31 AM
jdenny added inline comments.
llvm/test/FileCheck/verbose.txt
2–3

Sure, but how do you prefer to write -vv?

jhenderson added inline comments.Jun 29 2020, 7:09 AM
llvm/test/FileCheck/verbose.txt
2–3

Hmmm... good question! I'd probably do single dash, but don't mind either way.

jdenny marked an inline comment as done.Jun 29 2020, 8:19 AM
jdenny added inline comments.
llvm/test/FileCheck/verbose.txt
2–3

OK, I'll go with -- for everything here but -v and -vv. Thanks.

This revision was automatically updated to reflect the committed changes.
jdenny marked 2 inline comments as done.