Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
LGTM, with optional suggestion.
llvm/test/FileCheck/verbose.txt | ||
---|---|---|
2–3 | Can I make one minor suggestion whilst you're changing these lines: Change the single-dash arguments for double-dash (or vice versa, but I prefer the first). The reason is that there's an inconsistency in the number of dashes for different options, and it would be nice if it were consistent. It's not a big deal at all of course! |
llvm/test/FileCheck/verbose.txt | ||
---|---|---|
2–3 | Sure, but how do you prefer to write -vv? |
llvm/test/FileCheck/verbose.txt | ||
---|---|---|
2–3 | Hmmm... good question! I'd probably do single dash, but don't mind either way. |
llvm/test/FileCheck/verbose.txt | ||
---|---|---|
2–3 | OK, I'll go with -- for everything here but -v and -vv. Thanks. |
Can I make one minor suggestion whilst you're changing these lines: Change the single-dash arguments for double-dash (or vice versa, but I prefer the first). The reason is that there's an inconsistency in the number of dashes for different options, and it would be nice if it were consistent. It's not a big deal at all of course!