The legacy pass is called "loop-unroll", but in the new PM it's called "unroll".
Also applied to unroll-and-jam and unroll-full.
Fixes various check-llvm tests when NPM is turned on.
Paths
| Differential D82590
[NewPM][LoopUnroll] Rename unroll* to loop-unroll* ClosedPublic Authored by aeubanks on Jun 25 2020, 11:49 AM.
Details Summary The legacy pass is called "loop-unroll", but in the new PM it's called "unroll". Fixes various check-llvm tests when NPM is turned on.
Diff Detail
Event TimelineComment Actions How about change unroll to loop-unroll as well? In that case unroll and unroll-and-jam name can be more consistent, and their name can also be consistent between pass mangers. aeubanks added inline comments.
This revision is now accepted and ready to land.Jun 25 2020, 3:21 PM aeubanks retitled this revision from [NewPM][LoopUnrollAndJam] Rename unroll-and-jam to loop-unroll-and-jam to [NewPM][LoopUnroll] Rename unroll* to loop-unroll*.Jun 25 2020, 3:25 PM Comment Actions Fair enough. You could say that the extra 5 character are superfluous, but if consistency between old and new pass managers is useful to you then this sounds OK to me. Closed by commit rGa95796a380ed: [NewPM][LoopUnroll] Rename unroll* to loop-unroll* (authored by aeubanks). · Explain WhyJun 26 2020, 9:50 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 273764 llvm/lib/Passes/PassRegistry.def
llvm/test/Other/loop-pass-printer.ll
llvm/test/Transforms/Inline/last-call-bonus.ll
llvm/test/Transforms/Inline/last-call-no-bonus.ll
llvm/test/Transforms/LoopUnroll/basic.ll
llvm/test/Transforms/LoopUnroll/disable-full-unroll-by-opt.ll
llvm/test/Transforms/LoopUnroll/full-unroll-bad-cost.ll
llvm/test/Transforms/LoopUnroll/full-unroll-crashers.ll
llvm/test/Transforms/LoopUnroll/full-unroll-heuristics-2.ll
llvm/test/Transforms/LoopUnroll/full-unroll-heuristics-cmp.ll
llvm/test/Transforms/LoopUnroll/full-unroll-heuristics-dce.ll
llvm/test/Transforms/LoopUnroll/full-unroll-heuristics-geps.ll
llvm/test/Transforms/LoopUnroll/full-unroll-heuristics-phi-prop.ll
llvm/test/Transforms/LoopUnroll/full-unroll-heuristics.ll
llvm/test/Transforms/LoopUnroll/full-unroll-keep-first-exit.ll
llvm/test/Transforms/LoopUnroll/nonlatchcondbr.ll
llvm/test/Transforms/LoopUnroll/partial-unroll-const-bounds.ll
llvm/test/Transforms/LoopUnroll/peel-loop-inner.ll
llvm/test/Transforms/LoopUnroll/peel-loop-pgo-deopt-idom-2.ll
llvm/test/Transforms/LoopUnroll/peel-loop-pgo-deopt-idom.ll
llvm/test/Transforms/LoopUnroll/peel-loop-pgo-deopt.ll
llvm/test/Transforms/LoopUnroll/peel-loop-pgo.ll
llvm/test/Transforms/LoopUnroll/peel-loop.ll
llvm/test/Transforms/LoopUnroll/revisit.ll
llvm/test/Transforms/LoopUnroll/runtime-loop.ll
llvm/test/Transforms/LoopUnroll/runtime-loop1.ll
llvm/test/Transforms/LoopUnroll/runtime-loop2.ll
llvm/test/Transforms/LoopUnroll/runtime-loop3.ll
llvm/test/Transforms/LoopUnroll/runtime-loop5.ll
llvm/test/Transforms/LoopUnroll/unloop.ll
llvm/test/Transforms/LoopUnroll/unroll-loop-invalidation.ll
llvm/test/Transforms/LoopUnroll/unroll-opt-attribute.ll
llvm/test/Transforms/LoopUnroll/update-loop-info-in-subloops.ll
llvm/test/Transforms/LoopUnroll/wrong_assert_in_peeling.ll
llvm/test/Transforms/LoopUnrollAndJam/dependencies.ll
llvm/test/Transforms/LoopUnrollAndJam/dependencies_multidims.ll
llvm/test/Transforms/LoopUnrollAndJam/disable.ll
llvm/test/Transforms/LoopUnrollAndJam/innerloop.ll
llvm/test/Transforms/LoopUnrollAndJam/pragma-explicit.ll
llvm/test/Transforms/LoopUnrollAndJam/unroll-and-jam.ll
|
It's called "unroll". So why would it not be called "unroll-and-jam"?
(I have no real opinion on one vs the other, but seems more consistent to use a name similar to the unroll pass)